* [PATCH][drm-next] drm/panel: remove redundant assignment to val
@ 2019-08-17 12:21 Colin King
2019-08-17 14:55 ` Sam Ravnborg
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2019-08-17 12:21 UTC (permalink / raw)
To: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter,
dri-devel, linux-kernel
Cc: kernel-janitors
From: Colin Ian King <colin.king@canonical.com>
Variable val is initialized to a value in a for-loop that is
never read and hence it is redundant. Remove it.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpu/drm/panel/panel-tpo-td043mtea1.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panel/panel-tpo-td043mtea1.c b/drivers/gpu/drm/panel/panel-tpo-td043mtea1.c
index 3b4f30c0fdae..84370562910f 100644
--- a/drivers/gpu/drm/panel/panel-tpo-td043mtea1.c
+++ b/drivers/gpu/drm/panel/panel-tpo-td043mtea1.c
@@ -116,7 +116,7 @@ static void td043mtea1_write_gamma(struct td043mtea1_panel *lcd)
td043mtea1_write(lcd, 0x13, val);
/* gamma bits [7:0] */
- for (val = i = 0; i < 12; i++)
+ for (i = 0; i < 12; i++)
td043mtea1_write(lcd, 0x14 + i, gamma[i] & 0xff);
}
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH][drm-next] drm/panel: remove redundant assignment to val
2019-08-17 12:21 [PATCH][drm-next] drm/panel: remove redundant assignment to val Colin King
@ 2019-08-17 14:55 ` Sam Ravnborg
0 siblings, 0 replies; 2+ messages in thread
From: Sam Ravnborg @ 2019-08-17 14:55 UTC (permalink / raw)
To: Colin King, Laurent Pinchart
Cc: Thierry Reding, David Airlie, Daniel Vetter, dri-devel,
linux-kernel, kernel-janitors
On Sat, Aug 17, 2019 at 01:21:24PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable val is initialized to a value in a for-loop that is
> never read and hence it is redundant. Remove it.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks. Applied and pushed to drm-misc-next.
Sam
> ---
> drivers/gpu/drm/panel/panel-tpo-td043mtea1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-tpo-td043mtea1.c b/drivers/gpu/drm/panel/panel-tpo-td043mtea1.c
> index 3b4f30c0fdae..84370562910f 100644
> --- a/drivers/gpu/drm/panel/panel-tpo-td043mtea1.c
> +++ b/drivers/gpu/drm/panel/panel-tpo-td043mtea1.c
> @@ -116,7 +116,7 @@ static void td043mtea1_write_gamma(struct td043mtea1_panel *lcd)
> td043mtea1_write(lcd, 0x13, val);
>
> /* gamma bits [7:0] */
> - for (val = i = 0; i < 12; i++)
> + for (i = 0; i < 12; i++)
> td043mtea1_write(lcd, 0x14 + i, gamma[i] & 0xff);
> }
>
> --
> 2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-17 14:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-17 12:21 [PATCH][drm-next] drm/panel: remove redundant assignment to val Colin King
2019-08-17 14:55 ` Sam Ravnborg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®