* [PATCH] arm64: perf_event: Add missing header needed for smp_processor_id()
@ 2019-08-20 15:57 Raphael Gault
2019-08-20 16:06 ` Mark Rutland
0 siblings, 1 reply; 3+ messages in thread
From: Raphael Gault @ 2019-08-20 15:57 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel
Cc: mingo, peterz, catalin.marinas, will.deacon, acme, mark.rutland,
raph.gault+kdev, Raphael Gault
Acked-by: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Raphael Gault <raphael.gault@arm.com>
---
arch/arm64/kernel/perf_event.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/kernel/perf_event.c b/arch/arm64/kernel/perf_event.c
index 96e90e270042..24575c0a0065 100644
--- a/arch/arm64/kernel/perf_event.c
+++ b/arch/arm64/kernel/perf_event.c
@@ -19,6 +19,7 @@
#include <linux/of.h>
#include <linux/perf/arm_pmu.h>
#include <linux/platform_device.h>
+#include <linux/smp.h>
/* ARMv8 Cortex-A53 specific event types. */
#define ARMV8_A53_PERFCTR_PREF_LINEFILL 0xC2
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: perf_event: Add missing header needed for smp_processor_id()
2019-08-20 15:57 [PATCH] arm64: perf_event: Add missing header needed for smp_processor_id() Raphael Gault
@ 2019-08-20 16:06 ` Mark Rutland
2019-08-20 16:11 ` Will Deacon
0 siblings, 1 reply; 3+ messages in thread
From: Mark Rutland @ 2019-08-20 16:06 UTC (permalink / raw)
To: Raphael Gault
Cc: linux-arm-kernel, linux-kernel, mingo, peterz, catalin.marinas,
will.deacon, acme, raph.gault+kdev
On Tue, Aug 20, 2019 at 04:57:45PM +0100, Raphael Gault wrote:
It would be worth having a body for the commit message like:
| in perf_event.c we use smp_processor_id(), but we haven't included
| <linux/smp.h> where it is defined, and rely on this being pulled in
| via a transitive include. Let's make this more robust by including
| <linux.smp.h> explciitly.
... and with that, my Acked-by stands.
Thanks,
Mark.
> Acked-by: Mark Rutland <mark.rutland@arm.com>
> Signed-off-by: Raphael Gault <raphael.gault@arm.com>
> ---
> arch/arm64/kernel/perf_event.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/kernel/perf_event.c b/arch/arm64/kernel/perf_event.c
> index 96e90e270042..24575c0a0065 100644
> --- a/arch/arm64/kernel/perf_event.c
> +++ b/arch/arm64/kernel/perf_event.c
> @@ -19,6 +19,7 @@
> #include <linux/of.h>
> #include <linux/perf/arm_pmu.h>
> #include <linux/platform_device.h>
> +#include <linux/smp.h>
>
> /* ARMv8 Cortex-A53 specific event types. */
> #define ARMV8_A53_PERFCTR_PREF_LINEFILL 0xC2
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: perf_event: Add missing header needed for smp_processor_id()
2019-08-20 16:06 ` Mark Rutland
@ 2019-08-20 16:11 ` Will Deacon
0 siblings, 0 replies; 3+ messages in thread
From: Will Deacon @ 2019-08-20 16:11 UTC (permalink / raw)
To: Mark Rutland
Cc: Raphael Gault, raph.gault+kdev, peterz, catalin.marinas,
will.deacon, linux-kernel, acme, mingo, linux-arm-kernel
On Tue, Aug 20, 2019 at 05:06:29PM +0100, Mark Rutland wrote:
> On Tue, Aug 20, 2019 at 04:57:45PM +0100, Raphael Gault wrote:
>
> It would be worth having a body for the commit message like:
>
> | in perf_event.c we use smp_processor_id(), but we haven't included
> | <linux/smp.h> where it is defined, and rely on this being pulled in
> | via a transitive include. Let's make this more robust by including
> | <linux.smp.h> explciitly.
>
> ... and with that, my Acked-by stands.
Queued for 5.4. with typo fixed above.
Will
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-20 16:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-20 15:57 [PATCH] arm64: perf_event: Add missing header needed for smp_processor_id() Raphael Gault
2019-08-20 16:06 ` Mark Rutland
2019-08-20 16:11 ` Will Deacon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®