mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Diego Elio Pettenò" <flameeyes@flameeyes.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-kernel@vger.kernel.org,
	"Diego Elio Pettenò" <flameeyes@flameeyes.com>
Subject: [PATCH 3/4] cdrom: remove REVISION/VERSION constants that are awfully out of date.
Date: Mon, 26 Aug 2019 16:16:39 +0100	[thread overview]
Message-ID: <20190826151640.5036-4-flameeyes@flameeyes.com> (raw)
In-Reply-To: <20190826151640.5036-1-flameeyes@flameeyes.com>

This driver changed significantly since 2003, there's no point in it pretending to still be that.

Signed-off-by: Diego Elio Pettenò <flameeyes@flameeyes.com>
---
 drivers/cdrom/cdrom.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c
index ec1267d0a5c0..732aa7115ebd 100644
--- a/drivers/cdrom/cdrom.c
+++ b/drivers/cdrom/cdrom.c
@@ -244,9 +244,6 @@
 
 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
 
-#define REVISION "Revision: 3.20"
-#define VERSION "Id: cdrom.c 3.20 2003/12/17"
-
 #include <linux/atomic.h>
 #include <linux/module.h>
 #include <linux/fs.h>
@@ -559,7 +556,7 @@ int register_cdrom(struct cdrom_device_info *cdi)
 	if (cdo->open == NULL || cdo->release == NULL)
 		return -EINVAL;
 	if (!banner_printed) {
-		pr_info("Uniform CD-ROM driver " REVISION "\n");
+		pr_info("Uniform CD-ROM driver\n");
 		banner_printed = 1;
 		cdrom_sysctl_register();
 	}
@@ -3374,7 +3371,7 @@ static int cdrom_sysctl_info(struct ctl_table *ctl, int write,
 
 	mutex_lock(&cdrom_mutex);
 
-	pos = sprintf(info, "CD-ROM information, " VERSION "\n");
+	pos = sprintf(info, "CD-ROM information\n");
 	
 	if (cdrom_print_info("\ndrive name:\t", 0, info, &pos, CTL_NAME))
 		goto done;
-- 
2.22.0


  parent reply	other threads:[~2019-08-26 15:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-26 15:16 cdrom: debug info changes, Beurer glucometer support Diego Elio Pettenò
2019-08-26 15:16 ` [PATCH 1/4] cdrom: remove entering/exiting debug message logs Diego Elio Pettenò
2019-08-26 15:16 ` [PATCH 2/4] cdrom: make debug logging rely on pr_debug and debugfs only Diego Elio Pettenò
2019-11-03 16:00   ` Michal Suchánek
2019-11-11 12:21     ` Diego Elio Pettenò
2019-11-11 13:18       ` Michal Suchánek
2019-11-11 13:27         ` Diego Elio Pettenò
2019-08-26 15:16 ` Diego Elio Pettenò [this message]
2019-08-26 15:16 ` [PATCH 4/4] cdrom: support Beurer GL50 evo CD-on-a-chip devices Diego Elio Pettenò
2019-10-13 13:38 ` cdrom: debug info changes, Beurer glucometer support Diego Elio Pettenò

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190826151640.5036-4-flameeyes@flameeyes.com \
    --to=flameeyes@flameeyes.com \
    --cc=axboe@kernel.dk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®