mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Michal Suchánek" <msuchanek@suse.de>
To: "Diego Elio Pettenò" <flameeyes@flameeyes.com>
Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org
Subject: Re: cdrom: make debug logging rely on pr_debug and debugfs only.
Date: Mon, 11 Nov 2019 14:18:17 +0100	[thread overview]
Message-ID: <20191111131817.GA2770@kitsune.suse.cz> (raw)
In-Reply-To: <CAHcsgXRtWAt0mEQoW2rn1v6yYZ8ZKygKVetk4mnm_o+pwgwcVw@mail.gmail.com>

On Mon, Nov 11, 2019 at 12:21:38PM +0000, Diego Elio Pettenò wrote:
> On Sun, Nov 3, 2019 at 4:00 PM Michal Suchánek <msuchanek@suse.de> wrote:
> > can you change cd_dbg to a macro that always prints the device name
> > using pr_debug instead of removing it?
> 
> I can try doing that (need to figure out how, of course.)
> 
> Should I split the change that removes the debug parameter /
> ERRORLOGMASK parts? To be honest those are the parts that appear more
> of a duplication than the macro itself, so it might make sense to
> remove the custom debug selection, and then add the device name on top
> of that?

I wrote a patch that does just that because I am debugging an issue with
cdrom and I need to know which device the messages relate to.

Maybe you can drop this part entirely to not get conflicts.

Thanks

Michal

  reply	other threads:[~2019-11-11 13:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-26 15:16 cdrom: debug info changes, Beurer glucometer support Diego Elio Pettenò
2019-08-26 15:16 ` [PATCH 1/4] cdrom: remove entering/exiting debug message logs Diego Elio Pettenò
2019-08-26 15:16 ` [PATCH 2/4] cdrom: make debug logging rely on pr_debug and debugfs only Diego Elio Pettenò
2019-11-03 16:00   ` Michal Suchánek
2019-11-11 12:21     ` Diego Elio Pettenò
2019-11-11 13:18       ` Michal Suchánek [this message]
2019-11-11 13:27         ` Diego Elio Pettenò
2019-08-26 15:16 ` [PATCH 3/4] cdrom: remove REVISION/VERSION constants that are awfully out of date Diego Elio Pettenò
2019-08-26 15:16 ` [PATCH 4/4] cdrom: support Beurer GL50 evo CD-on-a-chip devices Diego Elio Pettenò
2019-10-13 13:38 ` cdrom: debug info changes, Beurer glucometer support Diego Elio Pettenò

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191111131817.GA2770@kitsune.suse.cz \
    --to=msuchanek@suse.de \
    --cc=axboe@kernel.dk \
    --cc=flameeyes@flameeyes.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®