From: Kees Cook <keescook@chromium.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Raul E Rangel <rrangel@chromium.org>
Cc: Arnd Bergmann <arnd@arndb.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lkdtm/bugs: fix build error in lkdtm_EXHAUST_STACK
Date: Tue, 27 Aug 2019 10:49:34 -0700 [thread overview]
Message-ID: <201908271048.A14E3F4C3@keescook> (raw)
In-Reply-To: <20190827164414.122478-1-rrangel@chromium.org>
On Tue, Aug 27, 2019 at 10:44:13AM -0600, Raul E Rangel wrote:
> Building an x86 64 bit kernel:
>
> lkdtm/bugs.c:94:2: error: format '%d' expects argument of type 'int', but argument 2 has type 'long unsigned int' [-Werror=format=]
> pr_info("Calling function with %d frame size to depth %d ...\n",
> ^
>
> Fixes: 24cccab42c419 ("lkdtm/bugs: Adjust recursion test to avoid elision")
>
> Signed-off-by: Raul E Rangel <rrangel@chromium.org>
Ah yes; thanks! I should build with W=1 more often. :)
Acked-by: Kees Cook <keescook@chromium.org>
Greg, can you take this into drivers/misc please?
-Kees
> ---
>
> drivers/misc/lkdtm/bugs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/lkdtm/bugs.c b/drivers/misc/lkdtm/bugs.c
> index 1606658b9b7e..bf945704f21a 100644
> --- a/drivers/misc/lkdtm/bugs.c
> +++ b/drivers/misc/lkdtm/bugs.c
> @@ -91,7 +91,7 @@ void lkdtm_LOOP(void)
>
> void lkdtm_EXHAUST_STACK(void)
> {
> - pr_info("Calling function with %d frame size to depth %d ...\n",
> + pr_info("Calling function with %lu frame size to depth %d ...\n",
> REC_STACK_SIZE, recur_count);
> recursive_loop(recur_count);
> pr_info("FAIL: survived without exhausting stack?!\n");
> --
> 2.23.0.187.g17f5b7556c-goog
>
--
Kees Cook
prev parent reply other threads:[~2019-08-28 17:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 16:44 Raul E Rangel
2019-08-27 17:49 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201908271048.A14E3F4C3@keescook \
--to=keescook@chromium.org \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rrangel@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®