* [PATCH] lkdtm/bugs: fix build error in lkdtm_EXHAUST_STACK
@ 2019-08-27 16:44 Raul E Rangel
2019-08-27 17:49 ` Kees Cook
0 siblings, 1 reply; 2+ messages in thread
From: Raul E Rangel @ 2019-08-27 16:44 UTC (permalink / raw)
To: keescook; +Cc: Raul E Rangel, Greg Kroah-Hartman, Arnd Bergmann, linux-kernel
Building an x86 64 bit kernel:
lkdtm/bugs.c:94:2: error: format '%d' expects argument of type 'int', but argument 2 has type 'long unsigned int' [-Werror=format=]
pr_info("Calling function with %d frame size to depth %d ...\n",
^
Fixes: 24cccab42c419 ("lkdtm/bugs: Adjust recursion test to avoid elision")
Signed-off-by: Raul E Rangel <rrangel@chromium.org>
---
drivers/misc/lkdtm/bugs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/lkdtm/bugs.c b/drivers/misc/lkdtm/bugs.c
index 1606658b9b7e..bf945704f21a 100644
--- a/drivers/misc/lkdtm/bugs.c
+++ b/drivers/misc/lkdtm/bugs.c
@@ -91,7 +91,7 @@ void lkdtm_LOOP(void)
void lkdtm_EXHAUST_STACK(void)
{
- pr_info("Calling function with %d frame size to depth %d ...\n",
+ pr_info("Calling function with %lu frame size to depth %d ...\n",
REC_STACK_SIZE, recur_count);
recursive_loop(recur_count);
pr_info("FAIL: survived without exhausting stack?!\n");
--
2.23.0.187.g17f5b7556c-goog
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] lkdtm/bugs: fix build error in lkdtm_EXHAUST_STACK
2019-08-27 16:44 [PATCH] lkdtm/bugs: fix build error in lkdtm_EXHAUST_STACK Raul E Rangel
@ 2019-08-27 17:49 ` Kees Cook
0 siblings, 0 replies; 2+ messages in thread
From: Kees Cook @ 2019-08-27 17:49 UTC (permalink / raw)
To: Greg Kroah-Hartman, Raul E Rangel; +Cc: Arnd Bergmann, linux-kernel
On Tue, Aug 27, 2019 at 10:44:13AM -0600, Raul E Rangel wrote:
> Building an x86 64 bit kernel:
>
> lkdtm/bugs.c:94:2: error: format '%d' expects argument of type 'int', but argument 2 has type 'long unsigned int' [-Werror=format=]
> pr_info("Calling function with %d frame size to depth %d ...\n",
> ^
>
> Fixes: 24cccab42c419 ("lkdtm/bugs: Adjust recursion test to avoid elision")
>
> Signed-off-by: Raul E Rangel <rrangel@chromium.org>
Ah yes; thanks! I should build with W=1 more often. :)
Acked-by: Kees Cook <keescook@chromium.org>
Greg, can you take this into drivers/misc please?
-Kees
> ---
>
> drivers/misc/lkdtm/bugs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/lkdtm/bugs.c b/drivers/misc/lkdtm/bugs.c
> index 1606658b9b7e..bf945704f21a 100644
> --- a/drivers/misc/lkdtm/bugs.c
> +++ b/drivers/misc/lkdtm/bugs.c
> @@ -91,7 +91,7 @@ void lkdtm_LOOP(void)
>
> void lkdtm_EXHAUST_STACK(void)
> {
> - pr_info("Calling function with %d frame size to depth %d ...\n",
> + pr_info("Calling function with %lu frame size to depth %d ...\n",
> REC_STACK_SIZE, recur_count);
> recursive_loop(recur_count);
> pr_info("FAIL: survived without exhausting stack?!\n");
> --
> 2.23.0.187.g17f5b7556c-goog
>
--
Kees Cook
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-28 17:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-27 16:44 [PATCH] lkdtm/bugs: fix build error in lkdtm_EXHAUST_STACK Raul E Rangel
2019-08-27 17:49 ` Kees Cook
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®