From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Alexander Dahl <ada@thorsis.com>, Julien Grall <julien.grall@arm.com>
Cc: linux-rt-users@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [ANNOUNCE] v5.2.10-rt5
Date: Tue, 27 Aug 2019 15:22:01 +0200 [thread overview]
Message-ID: <20190827132200.uj44quypjsqu3oup@linutronix.de> (raw)
In-Reply-To: <1775495.KgcFvHdtex@ada>
On 2019-08-27 14:34:19 [+0200], Alexander Dahl wrote:
> Hello Sebastian,
Hello Alexander,
> This causes build errors on my side now, I tested with the .config we use on
> our custom tree on a tag "v5.2.10-rt5-rebase", cross-compiling with gcc 7.3.1
> for ARCH=arm:
of course, !SMP. What about this:
diff --git a/kernel/time/hrtimer.c b/kernel/time/hrtimer.c
--- a/kernel/time/hrtimer.c
+++ b/kernel/time/hrtimer.c
@@ -934,7 +934,11 @@ void hrtimer_grab_expiry_lock(const struct hrtimer *timer)
{
struct hrtimer_clock_base *base = READ_ONCE(timer->base);
+#ifdef CONFIG_SMP
if (timer->is_soft && base != &migration_base) {
+#else
+ if (timer->is_soft && base && base->cpu_base) {
+#endif
spin_lock(&base->cpu_base->softirq_expiry_lock);
spin_unlock(&base->cpu_base->softirq_expiry_lock);
}
Sebastian
next prev parent reply other threads:[~2019-08-27 13:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 10:55 Sebastian Andrzej Siewior
2019-08-27 12:34 ` Alexander Dahl
2019-08-27 13:22 ` Sebastian Andrzej Siewior [this message]
2019-08-27 14:26 ` Alexander Dahl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190827132200.uj44quypjsqu3oup@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=ada@thorsis.com \
--cc=julien.grall@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®