From: Mark Brown <broonie@kernel.org>
To: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH 2/8] regulator: add support for SY8824C regulator
Date: Tue, 27 Aug 2019 20:44:37 +0100 [thread overview]
Message-ID: <20190827194437.GO23391@sirena.co.uk> (raw)
In-Reply-To: <20190827163418.1a32fc48@xhacker.debian>
[-- Attachment #1: Type: text/plain, Size: 515 bytes --]
On Tue, Aug 27, 2019 at 08:45:33AM +0000, Jisheng Zhang wrote:
This looks mostly good and I'll apply it, a couple of small
things though:
> @@ -0,0 +1,192 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * SY8824C regulator driver
> + *
Please send a patch which updates the entire comment block to be
C++ style so it looks consistent.
> +#define BUCK_EN (1 << 7)
> +#define MODE (1 << 6)
> +
Please also add prefixes to these to namespace them, especially
MODE is likely to collide with something later.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-08-27 19:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 8:44 [PATCH 0/8] regulator: support Silergy SY8824C/SY8824E etc Jisheng Zhang
2019-08-27 8:45 ` [PATCH 1/8] regulator: add binding for the SY8824C voltage regulator Jisheng Zhang
2019-08-27 8:45 ` [PATCH 2/8] regulator: add support for SY8824C regulator Jisheng Zhang
2019-08-27 19:44 ` Mark Brown [this message]
2019-08-28 3:38 ` Jisheng Zhang
2019-08-28 5:49 ` Jisheng Zhang
2019-08-28 10:13 ` Mark Brown
2019-08-27 8:46 ` [PATCH 3/8] dt-bindings: sy8824x: Document SY8824E support Jisheng Zhang
2019-08-27 8:47 ` [PATCH 4/8] regulator: sy8824x: add " Jisheng Zhang
2019-08-27 8:48 ` [PATCH 5/8] dt-bindings: sy8824x: Document SY20276 support Jisheng Zhang
2019-08-27 8:48 ` [PATCH 6/8] regulator: sy8824x: add " Jisheng Zhang
2019-08-27 8:49 ` [PATCH 7/8] dt-bindings: sy8824x: Document SY20278 support Jisheng Zhang
2019-08-27 8:49 ` [PATCH 8/8] regulator: sy8824x: add " Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190827194437.GO23391@sirena.co.uk \
--to=broonie@kernel.org \
--cc=Jisheng.Zhang@synaptics.com \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome