From: Nick Desaulniers <ndesaulniers@google.com>
To: miguel.ojeda.sandonis@gmail.com
Cc: sedat.dilek@gmail.com, will@kernel.org, jpoimboe@redhat.com,
naveen.n.rao@linux.vnet.ibm.com, davem@davemloft.net,
paul.burton@mips.com, clang-built-linux@googlegroups.com,
linux-kernel@vger.kernel.org,
Nick Desaulniers <ndesaulniers@google.com>
Subject: [PATCH v2 01/14] s390/boot: perfer __section from compiler_attributes.h
Date: Tue, 27 Aug 2019 13:39:54 -0700 [thread overview]
Message-ID: <20190827204007.201890-2-ndesaulniers@google.com> (raw)
In-Reply-To: <20190827204007.201890-1-ndesaulniers@google.com>
GCC unescapes escaped string section names while Clang does not. Because
__section uses the `#` stringification operator for the section name, it
doesn't need to be escaped.
This antipattern was found with:
$ grep -e __section\(\" -e __section__\(\" -r
Reported-by: Sedat Dilek <sedat.dilek@gmail.com>
Suggested-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
---
arch/s390/boot/startup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/s390/boot/startup.c b/arch/s390/boot/startup.c
index 7b0d05414618..26493c4ff04b 100644
--- a/arch/s390/boot/startup.c
+++ b/arch/s390/boot/startup.c
@@ -46,7 +46,7 @@ struct diag_ops __bootdata_preserved(diag_dma_ops) = {
.diag0c = _diag0c_dma,
.diag308_reset = _diag308_reset_dma
};
-static struct diag210 _diag210_tmp_dma __section(".dma.data");
+static struct diag210 _diag210_tmp_dma __section(.dma.data);
struct diag210 *__bootdata_preserved(__diag210_tmp_dma) = &_diag210_tmp_dma;
void _swsusp_reset_dma(void);
unsigned long __bootdata_preserved(__swsusp_reset_dma) = __pa(_swsusp_reset_dma);
--
2.23.0.187.g17f5b7556c-goog
next prev parent reply other threads:[~2019-08-27 20:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 20:39 [PATCH v2 00/14] treewide: prefer " Nick Desaulniers
2019-08-27 20:39 ` Nick Desaulniers [this message]
2019-08-27 20:39 ` [PATCH v2 02/14] include/linux/compiler.h: " Nick Desaulniers
2019-08-27 20:39 ` [PATCH v2 03/14] parisc: " Nick Desaulniers
2019-08-27 20:39 ` [PATCH v2 04/14] um: " Nick Desaulniers
2019-08-27 20:39 ` [PATCH v2 05/14] ia64: " Nick Desaulniers
2019-08-27 20:39 ` [PATCH v2 06/14] arm: " Nick Desaulniers
2019-08-27 20:40 ` [PATCH v2 07/14] mips: " Nick Desaulniers
2019-08-27 20:40 ` [PATCH v2 08/14] sparc: " Nick Desaulniers
2019-08-27 20:40 ` [PATCH v2 09/14] powerpc: prefer __section and __printf " Nick Desaulniers
2019-08-27 20:40 ` [PATCH v2 10/14] x86: prefer __section " Nick Desaulniers
2019-08-27 20:40 ` [PATCH v2 11/14] include/asm-generic: " Nick Desaulniers
2019-08-27 20:40 ` [PATCH v2 12/14] include/linux: " Nick Desaulniers
2019-08-27 20:40 ` [PATCH v2 13/14] include/linux/compiler.h: remove unused KENTRY macro Nick Desaulniers
2019-08-27 20:40 ` [PATCH v2 14/14] compiler_attributes.h: add note about __section Nick Desaulniers
2019-08-28 2:47 ` [PATCH v2 00/14] treewide: prefer __section from compiler_attributes.h Joe Perches
2019-08-28 22:44 ` Nick Desaulniers
2019-08-28 9:59 ` Sedat Dilek
2019-08-28 22:44 ` Nick Desaulniers
2019-08-29 9:05 ` Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190827204007.201890-2-ndesaulniers@google.com \
--to=ndesaulniers@google.com \
--cc=clang-built-linux@googlegroups.com \
--cc=davem@davemloft.net \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=paul.burton@mips.com \
--cc=sedat.dilek@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®