From: Joe Perches <joe@perches.com>
To: Nick Desaulniers <ndesaulniers@google.com>,
miguel.ojeda.sandonis@gmail.com
Cc: sedat.dilek@gmail.com, will@kernel.org, jpoimboe@redhat.com,
naveen.n.rao@linux.vnet.ibm.com, davem@davemloft.net,
paul.burton@mips.com, clang-built-linux@googlegroups.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 00/14] treewide: prefer __section from compiler_attributes.h
Date: Tue, 27 Aug 2019 19:47:51 -0700 [thread overview]
Message-ID: <e8851ba7888c433dac2ffa5d80f3289cd05940a3.camel@perches.com> (raw)
In-Reply-To: <20190827204007.201890-1-ndesaulniers@google.com>
On Tue, 2019-08-27 at 13:39 -0700, Nick Desaulniers wrote:
> GCC unescapes escaped string section names while Clang does not. Because
> __section uses the `#` stringification operator for the section name, it
> doesn't need to be escaped.
>
> This fixes an Oops observed in distro's that use systemd and not
> net.core.bpf_jit_enable=1, when their kernels are compiled with Clang.
>
> Instead, we should:
> 1. Prefer __section(.section_name_no_quotes).
> 2. Only use __attribute__((__section(".section"))) when creating the
Please use __ before and after section
i.e. __attribute__((__section__("<section_name>")))
next prev parent reply other threads:[~2019-08-28 2:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 20:39 Nick Desaulniers
2019-08-27 20:39 ` [PATCH v2 01/14] s390/boot: perfer " Nick Desaulniers
2019-08-27 20:39 ` [PATCH v2 02/14] include/linux/compiler.h: prefer " Nick Desaulniers
2019-08-27 20:39 ` [PATCH v2 03/14] parisc: " Nick Desaulniers
2019-08-27 20:39 ` [PATCH v2 04/14] um: " Nick Desaulniers
2019-08-27 20:39 ` [PATCH v2 05/14] ia64: " Nick Desaulniers
2019-08-27 20:39 ` [PATCH v2 06/14] arm: " Nick Desaulniers
2019-08-27 20:40 ` [PATCH v2 07/14] mips: " Nick Desaulniers
2019-08-27 20:40 ` [PATCH v2 08/14] sparc: " Nick Desaulniers
2019-08-27 20:40 ` [PATCH v2 09/14] powerpc: prefer __section and __printf " Nick Desaulniers
2019-08-27 20:40 ` [PATCH v2 10/14] x86: prefer __section " Nick Desaulniers
2019-08-27 20:40 ` [PATCH v2 11/14] include/asm-generic: " Nick Desaulniers
2019-08-27 20:40 ` [PATCH v2 12/14] include/linux: " Nick Desaulniers
2019-08-27 20:40 ` [PATCH v2 13/14] include/linux/compiler.h: remove unused KENTRY macro Nick Desaulniers
2019-08-27 20:40 ` [PATCH v2 14/14] compiler_attributes.h: add note about __section Nick Desaulniers
2019-08-28 2:47 ` Joe Perches [this message]
2019-08-28 22:44 ` [PATCH v2 00/14] treewide: prefer __section from compiler_attributes.h Nick Desaulniers
2019-08-28 9:59 ` Sedat Dilek
2019-08-28 22:44 ` Nick Desaulniers
2019-08-29 9:05 ` Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8851ba7888c433dac2ffa5d80f3289cd05940a3.camel@perches.com \
--to=joe@perches.com \
--cc=clang-built-linux@googlegroups.com \
--cc=davem@davemloft.net \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=ndesaulniers@google.com \
--cc=paul.burton@mips.com \
--cc=sedat.dilek@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®