From: David Miller <davem@davemloft.net>
To: johan@kernel.org
Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] hso: fix NULL-deref on tty open
Date: Tue, 01 Oct 2019 21:08:14 -0400 (EDT) [thread overview]
Message-ID: <20191001.210814.415335033876213685.davem@davemloft.net> (raw)
In-Reply-To: <20190930151241.25646-1-johan@kernel.org>
From: Johan Hovold <johan@kernel.org>
Date: Mon, 30 Sep 2019 17:12:41 +0200
> Fix NULL-pointer dereference on tty open due to a failure to handle a
> missing interrupt-in endpoint when probing modem ports:
>
> BUG: kernel NULL pointer dereference, address: 0000000000000006
> ...
> RIP: 0010:tiocmget_submit_urb+0x1c/0xe0 [hso]
> ...
> Call Trace:
> hso_start_serial_device+0xdc/0x140 [hso]
> hso_serial_open+0x118/0x1b0 [hso]
> tty_open+0xf1/0x490
>
> Fixes: 542f54823614 ("tty: Modem functions for the HSO driver")
> Signed-off-by: Johan Hovold <johan@kernel.org>
Applied, thanks.
prev parent reply other threads:[~2019-10-02 1:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 15:12 Johan Hovold
2019-10-02 1:08 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191001.210814.415335033876213685.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®