* [PATCH] staging: greybus: add blank line after declarations
@ 2019-10-05 21:00 Gabriela Bittencourt
2019-10-06 9:50 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Gabriela Bittencourt @ 2019-10-05 21:00 UTC (permalink / raw)
To: outreachy-kernel, johan, elder, gregkh, greybus-dev, devel, linux-kernel
Fix CHECK: add blank line after declarations
Signed-off-by: Gabriela Bittencourt <gabrielabittencourt00@gmail.com>
---
drivers/staging/greybus/control.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/greybus/control.h b/drivers/staging/greybus/control.h
index 3a29ec05f631..5a45d55349a1 100644
--- a/drivers/staging/greybus/control.h
+++ b/drivers/staging/greybus/control.h
@@ -24,6 +24,7 @@ struct gb_control {
char *vendor_string;
char *product_string;
};
+
#define to_gb_control(d) container_of(d, struct gb_control, dev)
struct gb_control *gb_control_create(struct gb_interface *intf);
--
2.20.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] staging: greybus: add blank line after declarations
2019-10-05 21:00 [PATCH] staging: greybus: add blank line after declarations Gabriela Bittencourt
@ 2019-10-06 9:50 ` Greg KH
2019-10-06 10:09 ` Joe Perches
0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2019-10-06 9:50 UTC (permalink / raw)
To: Gabriela Bittencourt
Cc: outreachy-kernel, johan, elder, greybus-dev, devel, linux-kernel
On Sat, Oct 05, 2019 at 06:00:46PM -0300, Gabriela Bittencourt wrote:
> Fix CHECK: add blank line after declarations
>
> Signed-off-by: Gabriela Bittencourt <gabrielabittencourt00@gmail.com>
> ---
> drivers/staging/greybus/control.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/greybus/control.h b/drivers/staging/greybus/control.h
> index 3a29ec05f631..5a45d55349a1 100644
> --- a/drivers/staging/greybus/control.h
> +++ b/drivers/staging/greybus/control.h
> @@ -24,6 +24,7 @@ struct gb_control {
> char *vendor_string;
> char *product_string;
> };
> +
> #define to_gb_control(d) container_of(d, struct gb_control, dev)
No, the original code is "better" here, it's a common pattern despite
what checkpatch.pl tells you, sorry.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] staging: greybus: add blank line after declarations
2019-10-06 9:50 ` Greg KH
@ 2019-10-06 10:09 ` Joe Perches
2019-10-06 11:24 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 4+ messages in thread
From: Joe Perches @ 2019-10-06 10:09 UTC (permalink / raw)
To: Greg KH, Gabriela Bittencourt
Cc: outreachy-kernel, johan, elder, greybus-dev, devel, linux-kernel
On Sun, 2019-10-06 at 11:50 +0200, Greg KH wrote:
> On Sat, Oct 05, 2019 at 06:00:46PM -0300, Gabriela Bittencourt wrote:
> > Fix CHECK: add blank line after declarations
[]
> > diff --git a/drivers/staging/greybus/control.h b/drivers/staging/greybus/control.h
[]
> > @@ -24,6 +24,7 @@ struct gb_control {
> > char *vendor_string;
> > char *product_string;
> > };
> > +
> > #define to_gb_control(d) container_of(d, struct gb_control, dev)
>
> No, the original code is "better" here, it's a common pattern despite
> what checkpatch.pl tells you, sorry.
Statistics please.
I believe it's not a common pattern.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Outreachy kernel] Re: [PATCH] staging: greybus: add blank line after declarations
2019-10-06 10:09 ` Joe Perches
@ 2019-10-06 11:24 ` Julia Lawall
0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2019-10-06 11:24 UTC (permalink / raw)
To: Joe Perches
Cc: Greg KH, Gabriela Bittencourt, outreachy-kernel, johan, elder,
greybus-dev, devel, linux-kernel
On Sun, 6 Oct 2019, Joe Perches wrote:
> On Sun, 2019-10-06 at 11:50 +0200, Greg KH wrote:
> > On Sat, Oct 05, 2019 at 06:00:46PM -0300, Gabriela Bittencourt wrote:
> > > Fix CHECK: add blank line after declarations
> []
> > > diff --git a/drivers/staging/greybus/control.h b/drivers/staging/greybus/control.h
> []
> > > @@ -24,6 +24,7 @@ struct gb_control {
> > > char *vendor_string;
> > > char *product_string;
> > > };
> > > +
> > > #define to_gb_control(d) container_of(d, struct gb_control, dev)
> >
> > No, the original code is "better" here, it's a common pattern despite
> > what checkpatch.pl tells you, sorry.
>
> Statistics please.
>
> I believe it's not a common pattern.
I get 464 that have a blank line before the container_of #define and 185
that have no blank line.
Of the 464 that have a blank line, 135 contain clk in the file name.
julia
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-10-06 11:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-05 21:00 [PATCH] staging: greybus: add blank line after declarations Gabriela Bittencourt
2019-10-06 9:50 ` Greg KH
2019-10-06 10:09 ` Joe Perches
2019-10-06 11:24 ` [Outreachy kernel] " Julia Lawall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®