Re: Patch "soundwire: fix regmap dependencies and align with other serial links" has been added to the 5.2-stable tree

Re: Patch "soundwire: fix regmap dependencies and align with other serial links" has been added to the 5.2-stable tree

[Greg KH]

On Sun, Oct 06, 2019 at 09:44:47AM -0400, Sasha Levin wrote:
> This is a note to let you know that I've just added the patch titled
> 
>     soundwire: fix regmap dependencies and align with other serial links
> 
> to the 5.2-stable tree which can be found at:
>     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> 
> The filename of the patch is:
>      soundwire-fix-regmap-dependencies-and-align-with-oth.patch
> and it can be found in the queue-5.2 subdirectory.
> 
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable@vger.kernel.org> know about it.
> 
> 
> 
> commit 3287dff699a585506096287541cc4414600899c7
> Author: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> Date:   Thu Jul 18 18:02:15 2019 -0500
> 
>     soundwire: fix regmap dependencies and align with other serial links
>     
>     [ Upstream commit 8676b3ca4673517650fd509d7fa586aff87b3c28 ]
>     
>     The existing code has a mixed select/depend usage which makes no sense.
>     
>     config SOUNDWIRE_BUS
>            tristate
>            select REGMAP_SOUNDWIRE
>     
>     config REGMAP_SOUNDWIRE
>             tristate
>             depends on SOUNDWIRE_BUS
>     
>     Let's remove one layer of Kconfig definitions and align with the
>     solutions used by all other serial links.
>     
>     Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>     Link: https://lore.kernel.org/r/20190718230215.18675-1-pierre-louis.bossart@linux.intel.com
>     Signed-off-by: Vinod Koul <vkoul@kernel.org>
>     Signed-off-by: Sasha Levin <sashal@kernel.org>
> 
> diff --git a/drivers/base/regmap/Kconfig b/drivers/base/regmap/Kconfig
> index 6ad5ef48b61ee..8cd2ac650b505 100644
> --- a/drivers/base/regmap/Kconfig
> +++ b/drivers/base/regmap/Kconfig
> @@ -44,7 +44,7 @@ config REGMAP_IRQ
>  
>  config REGMAP_SOUNDWIRE
>  	tristate
> -	depends on SOUNDWIRE_BUS
> +	depends on SOUNDWIRE
>  
>  config REGMAP_SCCB
>  	tristate
> diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig
> index 3a01cfd70fdcd..f518273cfbe3c 100644
> --- a/drivers/soundwire/Kconfig
> +++ b/drivers/soundwire/Kconfig
> @@ -4,7 +4,7 @@
>  #
>  
>  menuconfig SOUNDWIRE
> -	bool "SoundWire support"
> +	tristate "SoundWire support"
>  	help
>  	  SoundWire is a 2-Pin interface with data and clock line ratified
>  	  by the MIPI Alliance. SoundWire is used for transporting data
> @@ -17,17 +17,12 @@ if SOUNDWIRE
>  
>  comment "SoundWire Devices"
>  
> -config SOUNDWIRE_BUS
> -	tristate
> -	select REGMAP_SOUNDWIRE
> -
>  config SOUNDWIRE_CADENCE
>  	tristate
>  
>  config SOUNDWIRE_INTEL
>  	tristate "Intel SoundWire Master driver"
>  	select SOUNDWIRE_CADENCE
> -	select SOUNDWIRE_BUS
>  	depends on X86 && ACPI && SND_SOC
>  	help
>  	  SoundWire Intel Master driver.
> diff --git a/drivers/soundwire/Makefile b/drivers/soundwire/Makefile
> index fd99a831b92a0..45b7e50016539 100644
> --- a/drivers/soundwire/Makefile
> +++ b/drivers/soundwire/Makefile
> @@ -5,7 +5,7 @@
>  
>  #Bus Objs
>  soundwire-bus-objs := bus_type.o bus.o slave.o mipi_disco.o stream.o
> -obj-$(CONFIG_SOUNDWIRE_BUS) += soundwire-bus.o
> +obj-$(CONFIG_SOUNDWIRE) += soundwire-bus.o
>  
>  #Cadence Objs
>  soundwire-cadence-objs := cadence_master.o

Do any of these Kconfig changes actually fix any real issue?  It looks
like they are all just "cleanups" to me.  What problem are they solving?

thanks,

greg k-h