From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: "Maciej W. Rozycki" <macro@linux-mips.org>,
Colin King <colin.king@canonical.com>
Cc: "David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] netdevsim: fix spelling mistake "forbidded" -> "forbid"
Date: Tue, 8 Oct 2019 12:14:57 -0700 [thread overview]
Message-ID: <20191008121457.34b570be@cakuba.netronome.com> (raw)
In-Reply-To: <alpine.LFD.2.21.1910080921350.25653@eddie.linux-mips.org>
On Tue, 8 Oct 2019 09:29:58 +0100 (BST), Maciej W. Rozycki wrote:
> On Tue, 8 Oct 2019, Colin King wrote:
>
> > diff --git a/drivers/net/netdevsim/dev.c b/drivers/net/netdevsim/dev.c
> > index a3d7d39f231a..ff6ced5487b6 100644
> > --- a/drivers/net/netdevsim/dev.c
> > +++ b/drivers/net/netdevsim/dev.c
> > @@ -486,7 +486,7 @@ static int nsim_dev_reload_down(struct devlink *devlink, bool netns_change,
> > /* For testing purposes, user set debugfs dont_allow_reload
> > * value to true. So forbid it.
> > */
> > - NL_SET_ERR_MSG_MOD(extack, "User forbidded reload for testing purposes");
> > + NL_SET_ERR_MSG_MOD(extack, "User forbid the reload for testing purposes");
>
> If nitpicking about grammar, then FWIW I believe it should actually be:
>
> NL_SET_ERR_MSG_MOD(extack, "User forbade the reload for testing purposes");
>
> (and then:
>
> NL_SET_ERR_MSG_MOD(extack, "User set up the reload to fail for testing purposes");
>
> elsewhere).
So I consulted with someone vaguely British, and they said they'd use
"forbid" here, therefore I've applied the patch to net-next.
prev parent reply other threads:[~2019-10-08 19:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 8:17 Colin King
2019-10-08 8:29 ` Maciej W. Rozycki
2019-10-08 19:14 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191008121457.34b570be@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®