* [PATCH][next] netdevsim: fix spelling mistake "forbidded" -> "forbid"
@ 2019-10-08 8:17 Colin King
2019-10-08 8:29 ` Maciej W. Rozycki
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2019-10-08 8:17 UTC (permalink / raw)
To: Jakub Kicinski, David S . Miller, netdev; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
There is a spelling mistake in a NL_SET_ERR_MSG_MOD message. Fix it.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/netdevsim/dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/netdevsim/dev.c b/drivers/net/netdevsim/dev.c
index a3d7d39f231a..ff6ced5487b6 100644
--- a/drivers/net/netdevsim/dev.c
+++ b/drivers/net/netdevsim/dev.c
@@ -486,7 +486,7 @@ static int nsim_dev_reload_down(struct devlink *devlink, bool netns_change,
/* For testing purposes, user set debugfs dont_allow_reload
* value to true. So forbid it.
*/
- NL_SET_ERR_MSG_MOD(extack, "User forbidded reload for testing purposes");
+ NL_SET_ERR_MSG_MOD(extack, "User forbid the reload for testing purposes");
return -EOPNOTSUPP;
}
--
2.20.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][next] netdevsim: fix spelling mistake "forbidded" -> "forbid"
2019-10-08 8:17 [PATCH][next] netdevsim: fix spelling mistake "forbidded" -> "forbid" Colin King
@ 2019-10-08 8:29 ` Maciej W. Rozycki
2019-10-08 19:14 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Maciej W. Rozycki @ 2019-10-08 8:29 UTC (permalink / raw)
To: Colin King
Cc: Jakub Kicinski, David S . Miller, netdev, kernel-janitors, linux-kernel
On Tue, 8 Oct 2019, Colin King wrote:
> diff --git a/drivers/net/netdevsim/dev.c b/drivers/net/netdevsim/dev.c
> index a3d7d39f231a..ff6ced5487b6 100644
> --- a/drivers/net/netdevsim/dev.c
> +++ b/drivers/net/netdevsim/dev.c
> @@ -486,7 +486,7 @@ static int nsim_dev_reload_down(struct devlink *devlink, bool netns_change,
> /* For testing purposes, user set debugfs dont_allow_reload
> * value to true. So forbid it.
> */
> - NL_SET_ERR_MSG_MOD(extack, "User forbidded reload for testing purposes");
> + NL_SET_ERR_MSG_MOD(extack, "User forbid the reload for testing purposes");
If nitpicking about grammar, then FWIW I believe it should actually be:
NL_SET_ERR_MSG_MOD(extack, "User forbade the reload for testing purposes");
(and then:
NL_SET_ERR_MSG_MOD(extack, "User set up the reload to fail for testing purposes");
elsewhere).
Maciej
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][next] netdevsim: fix spelling mistake "forbidded" -> "forbid"
2019-10-08 8:29 ` Maciej W. Rozycki
@ 2019-10-08 19:14 ` Jakub Kicinski
0 siblings, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2019-10-08 19:14 UTC (permalink / raw)
To: Maciej W. Rozycki, Colin King
Cc: David S . Miller, netdev, kernel-janitors, linux-kernel
On Tue, 8 Oct 2019 09:29:58 +0100 (BST), Maciej W. Rozycki wrote:
> On Tue, 8 Oct 2019, Colin King wrote:
>
> > diff --git a/drivers/net/netdevsim/dev.c b/drivers/net/netdevsim/dev.c
> > index a3d7d39f231a..ff6ced5487b6 100644
> > --- a/drivers/net/netdevsim/dev.c
> > +++ b/drivers/net/netdevsim/dev.c
> > @@ -486,7 +486,7 @@ static int nsim_dev_reload_down(struct devlink *devlink, bool netns_change,
> > /* For testing purposes, user set debugfs dont_allow_reload
> > * value to true. So forbid it.
> > */
> > - NL_SET_ERR_MSG_MOD(extack, "User forbidded reload for testing purposes");
> > + NL_SET_ERR_MSG_MOD(extack, "User forbid the reload for testing purposes");
>
> If nitpicking about grammar, then FWIW I believe it should actually be:
>
> NL_SET_ERR_MSG_MOD(extack, "User forbade the reload for testing purposes");
>
> (and then:
>
> NL_SET_ERR_MSG_MOD(extack, "User set up the reload to fail for testing purposes");
>
> elsewhere).
So I consulted with someone vaguely British, and they said they'd use
"forbid" here, therefore I've applied the patch to net-next.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-08 19:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-08 8:17 [PATCH][next] netdevsim: fix spelling mistake "forbidded" -> "forbid" Colin King
2019-10-08 8:29 ` Maciej W. Rozycki
2019-10-08 19:14 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®