* [PATCH] drm/dp-mst: remove unused variable
@ 2019-10-14 12:53 Anders Roxell
2019-10-14 17:24 ` Sean Paul
0 siblings, 1 reply; 2+ messages in thread
From: Anders Roxell @ 2019-10-14 12:53 UTC (permalink / raw)
To: maarten.lankhorst, mripard, sean, airlied, daniel.vetter
Cc: dri-devel, linux-kernel, Anders Roxell
The variable 'dev' is no longer used and the compiler rightly complains
that it should be removed.
../drivers/gpu/drm/drm_dp_mst_topology.c: In function ‘drm_atomic_get_mst_topology_state’:
../drivers/gpu/drm/drm_dp_mst_topology.c:4187:21: warning: unused variable ‘dev’ [-Wunused-variable]
struct drm_device *dev = mgr->dev;
^~~
Rework to remove the unused variable.
Fixes: 83fa9842afe7 ("drm/dp-mst: Drop connection_mutex check")
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
drivers/gpu/drm/drm_dp_mst_topology.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c
index 9364e4f42975..9cccc5e63309 100644
--- a/drivers/gpu/drm/drm_dp_mst_topology.c
+++ b/drivers/gpu/drm/drm_dp_mst_topology.c
@@ -4184,8 +4184,6 @@ EXPORT_SYMBOL(drm_dp_mst_topology_state_funcs);
struct drm_dp_mst_topology_state *drm_atomic_get_mst_topology_state(struct drm_atomic_state *state,
struct drm_dp_mst_topology_mgr *mgr)
{
- struct drm_device *dev = mgr->dev;
-
return to_dp_mst_topology_state(drm_atomic_get_private_obj_state(state, &mgr->base));
}
EXPORT_SYMBOL(drm_atomic_get_mst_topology_state);
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] drm/dp-mst: remove unused variable
2019-10-14 12:53 [PATCH] drm/dp-mst: remove unused variable Anders Roxell
@ 2019-10-14 17:24 ` Sean Paul
0 siblings, 0 replies; 2+ messages in thread
From: Sean Paul @ 2019-10-14 17:24 UTC (permalink / raw)
To: Anders Roxell, Manasi Navare
Cc: Maarten Lankhorst, Maxime Ripard, Dave Airlie, Daniel Vetter,
dri-devel, LKML
On Mon, Oct 14, 2019 at 8:53 AM Anders Roxell <anders.roxell@linaro.org> wrote:
>
> The variable 'dev' is no longer used and the compiler rightly complains
> that it should be removed.
>
> ../drivers/gpu/drm/drm_dp_mst_topology.c: In function ‘drm_atomic_get_mst_topology_state’:
> ../drivers/gpu/drm/drm_dp_mst_topology.c:4187:21: warning: unused variable ‘dev’ [-Wunused-variable]
> struct drm_device *dev = mgr->dev;
> ^~~
>
> Rework to remove the unused variable.
>
> Fixes: 83fa9842afe7 ("drm/dp-mst: Drop connection_mutex check")
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
Hi Anders,
Thank you for your patch! Manasi has already posted a patch for this:
https://patchwork.freedesktop.org/patch/335358/
It's reviewed, so we're just waiting for it to land.
Sean
> ---
> drivers/gpu/drm/drm_dp_mst_topology.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c
> index 9364e4f42975..9cccc5e63309 100644
> --- a/drivers/gpu/drm/drm_dp_mst_topology.c
> +++ b/drivers/gpu/drm/drm_dp_mst_topology.c
> @@ -4184,8 +4184,6 @@ EXPORT_SYMBOL(drm_dp_mst_topology_state_funcs);
> struct drm_dp_mst_topology_state *drm_atomic_get_mst_topology_state(struct drm_atomic_state *state,
> struct drm_dp_mst_topology_mgr *mgr)
> {
> - struct drm_device *dev = mgr->dev;
> -
> return to_dp_mst_topology_state(drm_atomic_get_private_obj_state(state, &mgr->base));
> }
> EXPORT_SYMBOL(drm_atomic_get_mst_topology_state);
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-14 17:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-14 12:53 [PATCH] drm/dp-mst: remove unused variable Anders Roxell
2019-10-14 17:24 ` Sean Paul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®