mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] kernel/signal.c: spare fix on copy_siginfo_from_user_any()
@ 2019-10-15  9:28 Ben Dooks
  0 siblings, 0 replies; only message in thread
From: Ben Dooks @ 2019-10-15  9:28 UTC (permalink / raw)
  To: linux-kernel; +Cc: Ben Dooks, linux-kernel

The copy_siginfo_from_user_any() should have __user attribute
on the siginfo_t *info pointer. Fix the following sparse warnings
by adding __user.

kernel/signal.c:3676:46: warning: incorrect type in argument 2 (different address spaces)
kernel/signal.c:3676:46:    expected struct siginfo const [noderef] [usertype] <asn:1> *from
kernel/signal.c:3676:46:    got struct siginfo [usertype] *info
kernel/signal.c:3736:58: warning: incorrect type in argument 2 (different address spaces)
kernel/signal.c:3736:58:    expected struct siginfo [usertype] *info
kernel/signal.c:3736:58:    got struct siginfo [noderef] [usertype] <asn:1> *info

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: linux-kernel@vger.kernel.org
---
 kernel/signal.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/kernel/signal.c b/kernel/signal.c
index c4da1ef56fdf..94985c756693 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -3661,7 +3661,8 @@ static bool access_pidfd_pidns(struct pid *pid)
 	return true;
 }
 
-static int copy_siginfo_from_user_any(kernel_siginfo_t *kinfo, siginfo_t *info)
+static int copy_siginfo_from_user_any(kernel_siginfo_t *kinfo,
+				      siginfo_t __user *info)
 {
 #ifdef CONFIG_COMPAT
 	/*
-- 
2.23.0


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2019-10-15  9:28 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-15  9:28 [PATCH] kernel/signal.c: spare fix on copy_siginfo_from_user_any() Ben Dooks

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®