From: Andrew Morton <akpm@linux-foundation.org>
To: Joe Perches <joe@perches.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Andy Whitcroft <apw@canonical.com>,
Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] checkpatch.pl: Don't complain about nominal authors if there isn't one
Date: Tue, 15 Oct 2019 13:55:45 -0700 [thread overview]
Message-ID: <20191015135545.9a9234b05067a564f1fbd69d@linux-foundation.org> (raw)
In-Reply-To: <595dffd5c7ba9196522319d2e087c9c1a8e67104.camel@perches.com>
On Fri, 13 Sep 2019 08:34:28 -0700 Joe Perches <joe@perches.com> wrote:
> On Fri, 2019-09-13 at 10:22 -0400, Alan Stern wrote:
> > On Thu, 12 Sep 2019, Joe Perches wrote:
> >
> > > On Thu, 2019-09-12 at 16:55 -0400, Alan Stern wrote:
> > > > checkpatch.pl shouldn't warn about a "Missing Signed-off-by: line by
> > > > nominal patch author" if there is no nominal patch author. Without
> > > > this change, checkpatch always gives me the following warning:
> > > >
> > > > WARNING: Missing Signed-off-by: line by nominal patch author ''
> > >
> > > When/how does this occur? Example please.
> >
> > The patch itself is a good example. Attached to this email is the
> > patch file in the form I keep it (from quilt, not git; note that quilt
> > doesn't do a good job of handling the "---" line so I leave it out and
> > insert it when submitting the patch). Try saving the attachment and
> > running it through checkpatch.pl. Here's what I get:
>
> Andrew?
>
> Does checkpatch emit this warning for you on
> your quilt content?
Nope. All my patches always have From: and Subject: at the start of
changelog.
prev parent reply other threads:[~2019-10-15 20:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 20:55 Alan Stern
2019-09-12 21:09 ` Joe Perches
2019-09-13 14:22 ` Alan Stern
2019-09-13 15:34 ` Joe Perches
2019-10-15 20:27 ` Alan Stern
2019-10-15 20:55 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191015135545.9a9234b05067a564f1fbd69d@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®