From: Joe Perches <joe@perches.com>
To: Alan Stern <stern@rowland.harvard.edu>,
Andy Whitcroft <apw@canonical.com>
Cc: Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] checkpatch.pl: Don't complain about nominal authors if there isn't one
Date: Thu, 12 Sep 2019 14:09:03 -0700 [thread overview]
Message-ID: <e4f60b3f68bd214261b946f34ea0459098da00c3.camel@perches.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1909121651180.1305-100000@iolanthe.rowland.org>
On Thu, 2019-09-12 at 16:55 -0400, Alan Stern wrote:
> checkpatch.pl shouldn't warn about a "Missing Signed-off-by: line by
> nominal patch author" if there is no nominal patch author. Without
> this change, checkpatch always gives me the following warning:
>
> WARNING: Missing Signed-off-by: line by nominal patch author ''
When/how does this occur? Example please.
> Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
>
> ---
>
> scripts/checkpatch.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: usb-devel/scripts/checkpatch.pl
> ===================================================================
> --- usb-devel.orig/scripts/checkpatch.pl
> +++ usb-devel/scripts/checkpatch.pl
> @@ -6673,7 +6673,7 @@ sub process {
> if ($signoff == 0) {
> ERROR("MISSING_SIGN_OFF",
> "Missing Signed-off-by: line(s)\n");
> - } elsif (!$authorsignoff) {
> + } elsif ($author ne '' && !$authorsignoff) {
> WARN("NO_AUTHOR_SIGN_OFF",
> "Missing Signed-off-by: line by nominal patch author '$author'\n");
> }
>
next prev parent reply other threads:[~2019-09-12 21:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 20:55 Alan Stern
2019-09-12 21:09 ` Joe Perches [this message]
2019-09-13 14:22 ` Alan Stern
2019-09-13 15:34 ` Joe Perches
2019-10-15 20:27 ` Alan Stern
2019-10-15 20:55 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4f60b3f68bd214261b946f34ea0459098da00c3.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®