mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] decompressor: fix undeclared items
@ 2019-10-15 15:36 Ben Dooks (Codethink)
  0 siblings, 0 replies; only message in thread
From: Ben Dooks (Codethink) @ 2019-10-15 15:36 UTC (permalink / raw)
  To: linux-kernel
  Cc: Ben Dooks (Codethink), Russell King, linux-arm-kernel, linux-kernel

The follow items are not declared but also not exported
so use __attribute__((__externally_visible__)) to silence
the following sparse warnings:

 ./include/linux/decompress/mm.h:31:30: warning: symbol 'malloc_ptr' was not declared. Should it be static?
./include/linux/decompress/mm.h:32:20: warning: symbol 'malloc_count' was not declared. Should it be static?
arch/arm/boot/compressed/decompress.c:59:5: warning: symbol 'do_decompress' was not declared. Should it be static?

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Russell King <linux@armlinux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
---
 arch/arm/boot/compressed/decompress.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/compressed/decompress.c b/arch/arm/boot/compressed/decompress.c
index aa075d8372ea..8f4969916151 100644
--- a/arch/arm/boot/compressed/decompress.c
+++ b/arch/arm/boot/compressed/decompress.c
@@ -9,7 +9,7 @@
 #include "misc.h"
 
 #define STATIC static
-#define STATIC_RW_DATA	/* non-static please */
+#define STATIC_RW_DATA	__attribute__((__externally_visible__)) /* non-static please */
 
 /* Diagnostic functions */
 #ifdef DEBUG
@@ -56,7 +56,8 @@ extern char * strchrnul(const char *, int);
 #include "../../../../lib/decompress_unlz4.c"
 #endif
 
-int do_decompress(u8 *input, int len, u8 *output, void (*error)(char *x))
+int __attribute__((__externally_visible__))
+do_decompress(u8 *input, int len, u8 *output, void (*error)(char *x))
 {
 	return __decompress(input, len, NULL, NULL, output, 0, NULL, error);
 }
-- 
2.23.0


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2019-10-15 15:36 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-15 15:36 [PATCH] decompressor: fix undeclared items Ben Dooks (Codethink)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®