* [PATCH] gfs2: make gfs2_fs_parameters static
@ 2019-10-17 11:02 Ben Dooks (Codethink)
2019-10-17 11:41 ` [Cluster-devel] " Andrew Price
0 siblings, 1 reply; 3+ messages in thread
From: Ben Dooks (Codethink) @ 2019-10-17 11:02 UTC (permalink / raw)
To: linux-kernel
Cc: Ben Dooks (Codethink),
Bob Peterson, Andreas Gruenbacher, cluster-devel, linux-kernel
The gfs2_fs_parameters is not used outside the unit
it is declared in, so make it static.
Fixes the following sparse warning:
fs/gfs2/ops_fstype.c:1331:39: warning: symbol 'gfs2_fs_parameters' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Bob Peterson <rpeterso@redhat.com>
Cc: Andreas Gruenbacher <agruenba@redhat.com>
Cc: cluster-devel@redhat.com
Cc: linux-kernel@vger.kernel.org
---
fs/gfs2/ops_fstype.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c
index 681b44682b0d..ebdef1c5f580 100644
--- a/fs/gfs2/ops_fstype.c
+++ b/fs/gfs2/ops_fstype.c
@@ -1328,7 +1328,7 @@ static const struct fs_parameter_enum gfs2_param_enums[] = {
{}
};
-const struct fs_parameter_description gfs2_fs_parameters = {
+static const struct fs_parameter_description gfs2_fs_parameters = {
.name = "gfs2",
.specs = gfs2_param_specs,
.enums = gfs2_param_enums,
--
2.23.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Cluster-devel] [PATCH] gfs2: make gfs2_fs_parameters static
2019-10-17 11:02 [PATCH] gfs2: make gfs2_fs_parameters static Ben Dooks (Codethink)
@ 2019-10-17 11:41 ` Andrew Price
2019-10-17 12:46 ` Andreas Gruenbacher
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Price @ 2019-10-17 11:41 UTC (permalink / raw)
To: Ben Dooks (Codethink); +Cc: linux-kernel, cluster-devel, linux-kernel
On 17/10/2019 12:02, Ben Dooks (Codethink) wrote:
> The gfs2_fs_parameters is not used outside the unit
> it is declared in, so make it static.
>
> Fixes the following sparse warning:
>
> fs/gfs2/ops_fstype.c:1331:39: warning: symbol 'gfs2_fs_parameters' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> Cc: Bob Peterson <rpeterso@redhat.com>
> Cc: Andreas Gruenbacher <agruenba@redhat.com>
> Cc: cluster-devel@redhat.com
> Cc: linux-kernel@vger.kernel.org
> ---
> fs/gfs2/ops_fstype.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c
> index 681b44682b0d..ebdef1c5f580 100644
> --- a/fs/gfs2/ops_fstype.c
> +++ b/fs/gfs2/ops_fstype.c
> @@ -1328,7 +1328,7 @@ static const struct fs_parameter_enum gfs2_param_enums[] = {
> {}
> };
>
> -const struct fs_parameter_description gfs2_fs_parameters = {
> +static const struct fs_parameter_description gfs2_fs_parameters = {
> .name = "gfs2",
> .specs = gfs2_param_specs,
> .enums = gfs2_param_enums,
>
Looks good to me.
Thanks,
Andy
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Cluster-devel] [PATCH] gfs2: make gfs2_fs_parameters static
2019-10-17 11:41 ` [Cluster-devel] " Andrew Price
@ 2019-10-17 12:46 ` Andreas Gruenbacher
0 siblings, 0 replies; 3+ messages in thread
From: Andreas Gruenbacher @ 2019-10-17 12:46 UTC (permalink / raw)
To: Andrew Price; +Cc: Ben Dooks (Codethink), linux-kernel, cluster-devel, LKML
On Thu, Oct 17, 2019 at 1:42 PM Andrew Price <anprice@redhat.com> wrote:
> On 17/10/2019 12:02, Ben Dooks (Codethink) wrote:
> > The gfs2_fs_parameters is not used outside the unit
> > it is declared in, so make it static.
> >
> > Fixes the following sparse warning:
> >
> > fs/gfs2/ops_fstype.c:1331:39: warning: symbol 'gfs2_fs_parameters' was not declared. Should it be static?
> >
> > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> > ---
> > Cc: Bob Peterson <rpeterso@redhat.com>
> > Cc: Andreas Gruenbacher <agruenba@redhat.com>
> > Cc: cluster-devel@redhat.com
> > Cc: linux-kernel@vger.kernel.org
> > ---
> > fs/gfs2/ops_fstype.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c
> > index 681b44682b0d..ebdef1c5f580 100644
> > --- a/fs/gfs2/ops_fstype.c
> > +++ b/fs/gfs2/ops_fstype.c
> > @@ -1328,7 +1328,7 @@ static const struct fs_parameter_enum gfs2_param_enums[] = {
> > {}
> > };
> >
> > -const struct fs_parameter_description gfs2_fs_parameters = {
> > +static const struct fs_parameter_description gfs2_fs_parameters = {
> > .name = "gfs2",
> > .specs = gfs2_param_specs,
> > .enums = gfs2_param_enums,
> >
>
> Looks good to me.
Andy, I've added a reviewed-by tag for you and pushed this to for-next.
Thanks,
Andreas
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-17 12:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-17 11:02 [PATCH] gfs2: make gfs2_fs_parameters static Ben Dooks (Codethink)
2019-10-17 11:41 ` [Cluster-devel] " Andrew Price
2019-10-17 12:46 ` Andreas Gruenbacher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®