* [PATCH] xfs: add mising include of xfs_pnfs.h for missing declarations
@ 2019-10-22 15:32 Ben Dooks (Codethink)
2019-10-22 16:55 ` Darrick J. Wong
0 siblings, 1 reply; 2+ messages in thread
From: Ben Dooks (Codethink) @ 2019-10-22 15:32 UTC (permalink / raw)
To: linux-kernel
Cc: Ben Dooks (Codethink), Darrick J. Wong, linux-xfs, linux-kernel
The xfs_pnfs.c file is missing an include of xfs_pnfs.h to
add the prototypes of the functions it exports. Include this
file to fix the following sparse warnings:
fs/xfs/xfs_pnfs.c:27:1: warning: symbol 'xfs_break_leased_layouts' was not declared. Should it be static?
fs/xfs/xfs_pnfs.c:52:1: warning: symbol 'xfs_fs_get_uuid' was not declared. Should it be static?
fs/xfs/xfs_pnfs.c:77:1: warning: symbol 'xfs_fs_map_blocks' was not declared. Should it be static?
fs/xfs/xfs_pnfs.c:226:1: warning: symbol 'xfs_fs_commit_blocks' was not declared. Should it be static?
Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
---
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
fs/xfs/xfs_pnfs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/xfs/xfs_pnfs.c b/fs/xfs/xfs_pnfs.c
index a339bd5fa260..b2f6f1e3d9c4 100644
--- a/fs/xfs/xfs_pnfs.c
+++ b/fs/xfs/xfs_pnfs.c
@@ -12,6 +12,7 @@
#include "xfs_trans.h"
#include "xfs_bmap.h"
#include "xfs_iomap.h"
+#include "xfs_pnfs.h"
/*
* Ensure that we do not have any outstanding pNFS layouts that can be used by
--
2.23.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] xfs: add mising include of xfs_pnfs.h for missing declarations
2019-10-22 15:32 [PATCH] xfs: add mising include of xfs_pnfs.h for missing declarations Ben Dooks (Codethink)
@ 2019-10-22 16:55 ` Darrick J. Wong
0 siblings, 0 replies; 2+ messages in thread
From: Darrick J. Wong @ 2019-10-22 16:55 UTC (permalink / raw)
To: Ben Dooks (Codethink); +Cc: linux-kernel, linux-xfs, linux-kernel
On Tue, Oct 22, 2019 at 04:32:47PM +0100, Ben Dooks (Codethink) wrote:
> The xfs_pnfs.c file is missing an include of xfs_pnfs.h to
> add the prototypes of the functions it exports. Include this
> file to fix the following sparse warnings:
>
> fs/xfs/xfs_pnfs.c:27:1: warning: symbol 'xfs_break_leased_layouts' was not declared. Should it be static?
> fs/xfs/xfs_pnfs.c:52:1: warning: symbol 'xfs_fs_get_uuid' was not declared. Should it be static?
> fs/xfs/xfs_pnfs.c:77:1: warning: symbol 'xfs_fs_map_blocks' was not declared. Should it be static?
> fs/xfs/xfs_pnfs.c:226:1: warning: symbol 'xfs_fs_commit_blocks' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> Cc: "Darrick J. Wong" <darrick.wong@oracle.com>
> Cc: linux-xfs@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---
> fs/xfs/xfs_pnfs.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/xfs/xfs_pnfs.c b/fs/xfs/xfs_pnfs.c
> index a339bd5fa260..b2f6f1e3d9c4 100644
> --- a/fs/xfs/xfs_pnfs.c
> +++ b/fs/xfs/xfs_pnfs.c
> @@ -12,6 +12,7 @@
> #include "xfs_trans.h"
> #include "xfs_bmap.h"
> #include "xfs_iomap.h"
> +#include "xfs_pnfs.h"
>
> /*
> * Ensure that we do not have any outstanding pNFS layouts that can be used by
> --
> 2.23.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-22 16:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-22 15:32 [PATCH] xfs: add mising include of xfs_pnfs.h for missing declarations Ben Dooks (Codethink)
2019-10-22 16:55 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®