mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: daniel.thompson@linaro.org, arnd@arndb.de, broonie@kernel.org,
	linus.walleij@linaro.org
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, baohua@kernel.org,
	stephan@gerhold.net, Lee Jones <lee.jones@linaro.org>
Subject: [PATCH v3 06/10] x86: olpc-xo1-pm: Remove invocation of MFD's .enable()/.disable() call-backs
Date: Thu, 24 Oct 2019 17:38:28 +0100	[thread overview]
Message-ID: <20191024163832.31326-7-lee.jones@linaro.org> (raw)
In-Reply-To: <20191024163832.31326-1-lee.jones@linaro.org>

IO regions are now requested and released by this device's parent.

Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 arch/x86/platform/olpc/olpc-xo1-pm.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/arch/x86/platform/olpc/olpc-xo1-pm.c b/arch/x86/platform/olpc/olpc-xo1-pm.c
index e1a32062a375..f067ac780ba7 100644
--- a/arch/x86/platform/olpc/olpc-xo1-pm.c
+++ b/arch/x86/platform/olpc/olpc-xo1-pm.c
@@ -12,7 +12,6 @@
 #include <linux/platform_device.h>
 #include <linux/export.h>
 #include <linux/pm.h>
-#include <linux/mfd/core.h>
 #include <linux/suspend.h>
 #include <linux/olpc-ec.h>
 
@@ -120,16 +119,11 @@ static const struct platform_suspend_ops xo1_suspend_ops = {
 static int xo1_pm_probe(struct platform_device *pdev)
 {
 	struct resource *res;
-	int err;
 
 	/* don't run on non-XOs */
 	if (!machine_is_olpc())
 		return -ENODEV;
 
-	err = mfd_cell_enable(pdev);
-	if (err)
-		return err;
-
 	res = platform_get_resource(pdev, IORESOURCE_IO, 0);
 	if (!res) {
 		dev_err(&pdev->dev, "can't fetch device resource info\n");
@@ -152,8 +146,6 @@ static int xo1_pm_probe(struct platform_device *pdev)
 
 static int xo1_pm_remove(struct platform_device *pdev)
 {
-	mfd_cell_disable(pdev);
-
 	if (strcmp(pdev->name, "cs5535-pms") == 0)
 		pms_base = 0;
 	else if (strcmp(pdev->name, "olpc-xo1-pm-acpi") == 0)
-- 
2.17.1


  parent reply	other threads:[~2019-10-24 16:38 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-24 16:38 [PATCH v3 00/10] Simplify MFD Core Lee Jones
2019-10-24 16:38 ` [PATCH v3 01/10] mfd: cs5535-mfd: Use PLATFORM_DEVID_* defines and tidy error message Lee Jones
2019-10-24 16:38 ` [PATCH v3 02/10] mfd: cs5535-mfd: Remove mfd_cell->id hack Lee Jones
2019-10-25  8:36   ` Daniel Thompson
2019-10-24 16:38 ` [PATCH v3 03/10] mfd: cs5535-mfd: Request shared IO regions centrally Lee Jones
2019-10-25  8:50   ` Daniel Thompson
2019-10-24 16:38 ` [PATCH v3 04/10] mfd: cs5535-mfd: Register clients using their own dedicated MFD cell entries Lee Jones
2019-10-25  8:50   ` Daniel Thompson
2019-10-24 16:38 ` [PATCH v3 05/10] mfd: mfd-core: Remove mfd_clone_cell() Lee Jones
2019-10-24 16:38 ` Lee Jones [this message]
2019-10-25  8:53   ` [PATCH v3 06/10] x86: olpc-xo1-pm: Remove invocation of MFD's .enable()/.disable() call-backs Daniel Thompson
2019-10-24 16:38 ` [PATCH v3 07/10] x86: olpc-xo1-sci: " Lee Jones
2019-10-25  8:54   ` Daniel Thompson
2019-10-24 16:38 ` [PATCH v3 08/10] mfd: mfd-core: Protect against NULL call-back function pointer Lee Jones
2019-10-25  8:52   ` Daniel Thompson
2019-10-25 14:55   ` Mark Brown
2019-10-24 16:38 ` [PATCH v3 09/10] mfd: mfd-core: Remove usage counting for .{en,dis}able() call-backs Lee Jones
2019-10-25 14:55   ` Mark Brown
2019-10-24 16:38 ` [PATCH v3 10/10] mfd: mfd-core: Move pdev->mfd_cell creation back into mfd_add_device() Lee Jones
2019-10-25  8:56   ` Daniel Thompson
2019-10-25 14:56   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191024163832.31326-7-lee.jones@linaro.org \
    --to=lee.jones@linaro.org \
    --cc=arnd@arndb.de \
    --cc=baohua@kernel.org \
    --cc=broonie@kernel.org \
    --cc=daniel.thompson@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stephan@gerhold.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®