From: David Miller <davem@davemloft.net>
To: dima@arista.com
Cc: linux-kernel@vger.kernel.org, 0x7f454c46@gmail.com,
akpm@linux-foundation.org, gregkh@linuxfoundation.org,
mingo@kernel.org, jslaby@suse.com, pmladek@suse.com,
sergey.senozhatsky@gmail.com, rostedt@goodmis.org,
penguin-kernel@I-love.SAKURA.ne.jp, sparclinux@vger.kernel.org
Subject: Re: [PATCH 34/50] sparc: Add show_stack_loglvl()
Date: Tue, 05 Nov 2019 19:33:27 -0800 (PST) [thread overview]
Message-ID: <20191105.193327.1393649190609263166.davem@davemloft.net> (raw)
In-Reply-To: <20191106030542.868541-35-dima@arista.com>
From: Dmitry Safonov <dima@arista.com>
Date: Wed, 6 Nov 2019 03:05:25 +0000
> Currently, the log-level of show_stack() depends on a platform
> realization. It creates situations where the headers are printed with
> lower log level or higher than the stacktrace (depending on
> a platform or user).
>
> Furthermore, it forces the logic decision from user to an architecture
> side. In result, some users as sysrq/kdb/etc are doing tricks with
> temporary rising console_loglevel while printing their messages.
> And in result it not only may print unwanted messages from other CPUs,
> but also omit printing at all in the unlucky case where the printk()
> was deferred.
>
> Introducing log-level parameter and KERN_UNSUPPRESSED [1] seems
> an easier approach than introducing more printk buffers.
> Also, it will consolidate printings with headers.
>
> Introduce show_stack_loglvl(), that eventually will substitute
> show_stack().
>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: sparclinux@vger.kernel.org
> [1]: https://lore.kernel.org/lkml/20190528002412.1625-1-dima@arista.com/T/#u
> Signed-off-by: Dmitry Safonov <dima@arista.com>
Acked-by: David S. Miller <davem@davemloft.net>
next prev parent reply other threads:[~2019-11-06 3:41 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191106030542.868541-1-dima@arista.com>
2019-11-06 3:04 ` [PATCH 01/50] kallsyms/printk: Add loglvl to print_ip_sym() Dmitry Safonov
2019-11-06 4:38 ` Sergey Senozhatsky
2019-11-06 16:39 ` Dmitry Safonov
2019-11-13 15:49 ` Steven Rostedt
2019-11-06 3:04 ` [PATCH 02/50] alpha: Add show_stack_loglvl() Dmitry Safonov
2019-11-06 3:04 ` [PATCH 03/50] arc: " Dmitry Safonov
2019-11-06 3:04 ` [PATCH 04/50] arm/asm: Add loglvl to c_backtrace() Dmitry Safonov
2019-11-06 3:04 ` [PATCH 05/50] arm: Add loglvl to unwind_backtrace() Dmitry Safonov
2019-11-06 9:12 ` Russell King - ARM Linux admin
2019-11-06 16:32 ` Dmitry Safonov
2019-11-06 3:04 ` [PATCH 06/50] arm: Add loglvl to dump_backtrace() Dmitry Safonov
2019-11-06 3:04 ` [PATCH 07/50] arm: Wire up dump_backtrace_{entry,stm} Dmitry Safonov
2019-11-06 3:04 ` [PATCH 08/50] arm: Add show_stack_loglvl() Dmitry Safonov
2019-11-06 3:05 ` [PATCH 09/50] arm64: Add loglvl to dump_backtrace() Dmitry Safonov
2019-11-06 13:25 ` Will Deacon
2019-11-06 16:00 ` Dmitry Safonov
2019-11-06 3:05 ` [PATCH 10/50] arm64: Add show_stack_loglvl() Dmitry Safonov
2019-11-06 3:05 ` [PATCH 11/50] c6x: " Dmitry Safonov
2019-11-06 3:05 ` [PATCH 12/50] csky: " Dmitry Safonov
2019-11-06 3:05 ` [PATCH 13/50] h8300: " Dmitry Safonov
2019-11-06 3:05 ` [PATCH 14/50] hexagon: " Dmitry Safonov
2019-11-06 3:05 ` [PATCH 15/50] ia64: Pass log level as arg into ia64_do_show_stack() Dmitry Safonov
2019-11-06 3:05 ` [PATCH 16/50] ia64: Add show_stack_loglvl() Dmitry Safonov
2019-11-06 3:05 ` [PATCH 17/50] m68k: " Dmitry Safonov
2019-11-06 3:05 ` [PATCH 18/50] microblaze: Add loglvl to microblaze_unwind_inner() Dmitry Safonov
2019-11-07 8:59 ` Michal Simek
2019-11-08 7:52 ` kbuild test robot
2019-11-06 3:05 ` [PATCH 19/50] microblaze: Add loglvl to microblaze_unwind() Dmitry Safonov
2019-11-06 3:05 ` [PATCH 20/50] microblaze: Add show_stack_loglvl() Dmitry Safonov
2019-11-06 3:05 ` [PATCH 21/50] mips: " Dmitry Safonov
2019-11-06 3:05 ` [PATCH 22/50] nds32: " Dmitry Safonov
2019-11-06 3:05 ` [PATCH 23/50] nios2: " Dmitry Safonov
2019-11-06 3:05 ` [PATCH 24/50] openrisc: " Dmitry Safonov
2019-11-06 3:05 ` [PATCH 25/50] parisc: " Dmitry Safonov
2019-11-06 3:05 ` [PATCH 26/50] powerpc: " Dmitry Safonov
2019-11-06 9:52 ` Michael Ellerman
2019-11-06 16:01 ` Dmitry Safonov
2019-11-06 3:05 ` [PATCH 27/50] riscv: " Dmitry Safonov
2019-11-06 3:05 ` [PATCH 28/50] s390: " Dmitry Safonov
2019-11-06 3:05 ` [PATCH 29/50] sh: Add loglvl to dump_mem() Dmitry Safonov
2019-11-06 3:05 ` [PATCH 30/50] sh: Remove needless printk() Dmitry Safonov
2019-11-06 3:05 ` [PATCH 31/50] sh: Add loglvl to printk_address() Dmitry Safonov
2019-11-06 3:05 ` [PATCH 32/50] sh: Add loglvl to show_trace() Dmitry Safonov
2019-11-06 3:05 ` [PATCH 33/50] sh: Add show_stack_loglvl() Dmitry Safonov
2019-11-06 3:05 ` [PATCH 34/50] sparc: " Dmitry Safonov
2019-11-06 3:33 ` David Miller [this message]
2019-11-06 16:02 ` Dmitry Safonov
2019-11-08 7:08 ` kbuild test robot
2019-11-06 3:05 ` [PATCH 35/50] um/sysrq: Remove needless variable sp Dmitry Safonov
2019-11-06 3:05 ` [PATCH 36/50] um: Add show_stack_loglvl() Dmitry Safonov
2019-11-06 3:05 ` [PATCH 37/50] unicore32: Remove unused pmode argument in c_backtrace() Dmitry Safonov
2019-11-06 3:05 ` [PATCH 38/50] unicore32: Add loglvl to c_backtrace() Dmitry Safonov
2019-11-06 3:05 ` [PATCH 39/50] unicore32: Add show_stack_loglvl() Dmitry Safonov
2019-11-06 3:05 ` [PATCH 40/50] x86: Add missing const qualifiers for log_lvl Dmitry Safonov
2019-11-06 3:05 ` [PATCH 41/50] x86: Add show_stack_loglvl() Dmitry Safonov
2019-11-06 3:05 ` [PATCH 42/50] xtensa: Add loglvl to show_trace() Dmitry Safonov
2019-11-06 3:05 ` [PATCH 43/50] xtensa: Add show_stack_loglvl() Dmitry Safonov
2019-11-06 4:13 ` Max Filippov
2019-11-06 8:15 ` Petr Mladek
2019-11-06 16:06 ` Dmitry Safonov
2019-11-06 16:44 ` Max Filippov
2019-11-06 3:05 ` [PATCH 44/50] sysrq: Use show_stack_loglvl() Dmitry Safonov
2019-11-06 3:05 ` [PATCH 45/50] x86/amd_gart: Print stacktrace for a leak with KERN_ERR Dmitry Safonov
2019-11-06 3:05 ` [PATCH 46/50] power: Use show_stack_loglvl() Dmitry Safonov
2019-11-06 3:05 ` [PATCH 47/50] kdb: Don't play with console_loglevel Dmitry Safonov
2019-11-06 3:05 ` [PATCH 48/50] sched: Print stack trace with KERN_INFO Dmitry Safonov
2019-11-06 3:05 ` [PATCH 49/50] kernel: Use show_stack_loglvl() Dmitry Safonov
2019-11-06 3:05 ` [PATCH 50/50] kernel: Rename show_stack_loglvl() => show_stack() Dmitry Safonov
2019-11-08 10:08 ` kbuild test robot
[not found] ` <20191106092039.GT4131@hirez.programming.kicks-ass.net>
[not found] ` <10db6fa1-5b17-ebe6-09e0-6335e09e4db8@arista.com>
[not found] ` <20191106203440.GH3079@worktop.programming.kicks-ass.net>
[not found] ` <20191106232512.GU25745@shell.armlinux.org.uk>
2019-11-07 7:27 ` [PATCH 00/50] Add log level to show_stack() Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191105.193327.1393649190609263166.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=0x7f454c46@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dima@arista.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®