mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dmitry Safonov <dima@arista.com>
To: Petr Mladek <pmladek@suse.com>, Max Filippov <jcmvbkbc@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Dmitry Safonov <0x7f454c46@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Ingo Molnar <mingo@kernel.org>, Jiri Slaby <jslaby@suse.com>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
	Chris Zankel <chris@zankel.net>,
	"open list:TENSILICA XTENSA PORT (xtensa)" 
	<linux-xtensa@linux-xtensa.org>
Subject: Re: [PATCH 43/50] xtensa: Add show_stack_loglvl()
Date: Wed, 6 Nov 2019 16:06:44 +0000	[thread overview]
Message-ID: <836351a4-581d-325f-862f-99c0c4f98e19@arista.com> (raw)
In-Reply-To: <20191106081541.soxefwyvu3o72tqg@pathway.suse.cz>

On 11/6/19 8:15 AM, Petr Mladek wrote:
> On Tue 2019-11-05 20:13:22, Max Filippov wrote:
[..]
>>> @@ -511,16 +512,21 @@ void show_stack(struct task_struct *task, unsigned long *sp)
>>>                 sp = stack_pointer(task);
>>>         stack = sp;
>>>
>>> -       pr_info("Stack:\n");
>>> +       printk("%sStack:\n", loglvl);
>>>
>>>         for (i = 0; i < kstack_depth_to_print; i++) {
>>>                 if (kstack_end(sp))
>>>                         break;
>>> -               pr_cont(" %08lx", *sp++);
>>> +               printk("%s %08lx", loglvl, *sp++);
> 
> KERN_CONT can be combined with any other loglevel.
> So you could keep using pr_cont() together with explicit loglevel:
> 
> 			pr_cont("%s %08lx", loglvl, *sp++);

Yes, that's what I had, but than misread the printk() code and thought
that it doesn't add '\n' to messages.. Will fix.

> It should fix the problems reported below.
> 
> Well, the preferred solution would be to snprintf() the continuous
> line into a temporary buffer. And printk() it when it is complete.
> pr_cont() is not reliable when more CPUs print at the same time.

Yep. Not sure if doing it now in those per-arch patches or keep the
changes to minimum.

> 
>> This change doesn't work well with printk timestamps, it changes
>> the following output on xtensa architecture
>>
>> [    3.404675] Stack:
>> [    3.404861]  a05773e2 00000018 bb03dc34 bb03dc30 a0008640 bb03dc70
>> ba9ba410 37c3f000
>> [    3.405414]  37c3f000 d7c3f000 00000800 bb03dc50 a02b97ed bb03dc90
>> ba9ba400 ba9ba410
>> [    3.405969]  a05fc1bc bbff28dc 00000000 bb03dc70 a02b7fb9 bb03dce0
>> ba9ba410 a0579044
>>
>> into this:
>> [    3.056825] Stack:
>> [    3.056963]  a04ebb20
>> [    3.056995]  bb03dc10
>> [    3.057138]  00000001
>> [    3.057277]  bb03dc10
>> [    3.057815]  a00083ca
>> [    3.057965]  bb03dc50
>> [    3.058107]  ba9ba410
>> [    3.058247]  37c3f000
>> [    3.058387]
>> [    3.058584]  a05773e2
>> [    3.058614]  00000001
>> [    3.058755]  a05ca0bc
>> [    3.058896]  bb03dc30
>> [    3.059035]  a000865c
>> [    3.059180]  bb03dc70
>> [    3.059319]  ba9ba410
>> [    3.059459]  37c3f000
>> [    3.059598]
>> [    3.059795]  37c3f000
>> [    3.059824]  d7c3f000
>> [    3.059964]  00000800
>> [    3.060103]  bb03dc50
>> [    3.060241]  a02b9809
>> [    3.060379]  bb03dc90
>> [    3.060519]  ba9ba400
>> [    3.060658]  ba9ba410
>> [    3.060796]

Hey Max,

thanks for the testing and the report - will fix it in v2.

Thanks,
          Dmitry

  reply	other threads:[~2019-11-06 16:06 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20191106030542.868541-1-dima@arista.com>
2019-11-06  3:04 ` [PATCH 01/50] kallsyms/printk: Add loglvl to print_ip_sym() Dmitry Safonov
2019-11-06  4:38   ` Sergey Senozhatsky
2019-11-06 16:39     ` Dmitry Safonov
2019-11-13 15:49   ` Steven Rostedt
2019-11-06  3:04 ` [PATCH 02/50] alpha: Add show_stack_loglvl() Dmitry Safonov
2019-11-06  3:04 ` [PATCH 03/50] arc: " Dmitry Safonov
2019-11-06  3:04 ` [PATCH 04/50] arm/asm: Add loglvl to c_backtrace() Dmitry Safonov
2019-11-06  3:04 ` [PATCH 05/50] arm: Add loglvl to unwind_backtrace() Dmitry Safonov
2019-11-06  9:12   ` Russell King - ARM Linux admin
2019-11-06 16:32     ` Dmitry Safonov
2019-11-06  3:04 ` [PATCH 06/50] arm: Add loglvl to dump_backtrace() Dmitry Safonov
2019-11-06  3:04 ` [PATCH 07/50] arm: Wire up dump_backtrace_{entry,stm} Dmitry Safonov
2019-11-06  3:04 ` [PATCH 08/50] arm: Add show_stack_loglvl() Dmitry Safonov
2019-11-06  3:05 ` [PATCH 09/50] arm64: Add loglvl to dump_backtrace() Dmitry Safonov
2019-11-06 13:25   ` Will Deacon
2019-11-06 16:00     ` Dmitry Safonov
2019-11-06  3:05 ` [PATCH 10/50] arm64: Add show_stack_loglvl() Dmitry Safonov
2019-11-06  3:05 ` [PATCH 11/50] c6x: " Dmitry Safonov
2019-11-06  3:05 ` [PATCH 12/50] csky: " Dmitry Safonov
2019-11-06  3:05 ` [PATCH 13/50] h8300: " Dmitry Safonov
2019-11-06  3:05 ` [PATCH 14/50] hexagon: " Dmitry Safonov
2019-11-06  3:05 ` [PATCH 15/50] ia64: Pass log level as arg into ia64_do_show_stack() Dmitry Safonov
2019-11-06  3:05 ` [PATCH 16/50] ia64: Add show_stack_loglvl() Dmitry Safonov
2019-11-06  3:05 ` [PATCH 17/50] m68k: " Dmitry Safonov
2019-11-06  3:05 ` [PATCH 18/50] microblaze: Add loglvl to microblaze_unwind_inner() Dmitry Safonov
2019-11-07  8:59   ` Michal Simek
2019-11-08  7:52   ` kbuild test robot
2019-11-06  3:05 ` [PATCH 19/50] microblaze: Add loglvl to microblaze_unwind() Dmitry Safonov
2019-11-06  3:05 ` [PATCH 20/50] microblaze: Add show_stack_loglvl() Dmitry Safonov
2019-11-06  3:05 ` [PATCH 21/50] mips: " Dmitry Safonov
2019-11-06  3:05 ` [PATCH 22/50] nds32: " Dmitry Safonov
2019-11-06  3:05 ` [PATCH 23/50] nios2: " Dmitry Safonov
2019-11-06  3:05 ` [PATCH 24/50] openrisc: " Dmitry Safonov
2019-11-06  3:05 ` [PATCH 25/50] parisc: " Dmitry Safonov
2019-11-06  3:05 ` [PATCH 26/50] powerpc: " Dmitry Safonov
2019-11-06  9:52   ` Michael Ellerman
2019-11-06 16:01     ` Dmitry Safonov
2019-11-06  3:05 ` [PATCH 27/50] riscv: " Dmitry Safonov
2019-11-06  3:05 ` [PATCH 28/50] s390: " Dmitry Safonov
2019-11-06  3:05 ` [PATCH 29/50] sh: Add loglvl to dump_mem() Dmitry Safonov
2019-11-06  3:05 ` [PATCH 30/50] sh: Remove needless printk() Dmitry Safonov
2019-11-06  3:05 ` [PATCH 31/50] sh: Add loglvl to printk_address() Dmitry Safonov
2019-11-06  3:05 ` [PATCH 32/50] sh: Add loglvl to show_trace() Dmitry Safonov
2019-11-06  3:05 ` [PATCH 33/50] sh: Add show_stack_loglvl() Dmitry Safonov
2019-11-06  3:05 ` [PATCH 34/50] sparc: " Dmitry Safonov
2019-11-06  3:33   ` David Miller
2019-11-06 16:02     ` Dmitry Safonov
2019-11-08  7:08   ` kbuild test robot
2019-11-06  3:05 ` [PATCH 35/50] um/sysrq: Remove needless variable sp Dmitry Safonov
2019-11-06  3:05 ` [PATCH 36/50] um: Add show_stack_loglvl() Dmitry Safonov
2019-11-06  3:05 ` [PATCH 37/50] unicore32: Remove unused pmode argument in c_backtrace() Dmitry Safonov
2019-11-06  3:05 ` [PATCH 38/50] unicore32: Add loglvl to c_backtrace() Dmitry Safonov
2019-11-06  3:05 ` [PATCH 39/50] unicore32: Add show_stack_loglvl() Dmitry Safonov
2019-11-06  3:05 ` [PATCH 40/50] x86: Add missing const qualifiers for log_lvl Dmitry Safonov
2019-11-06  3:05 ` [PATCH 41/50] x86: Add show_stack_loglvl() Dmitry Safonov
2019-11-06  3:05 ` [PATCH 42/50] xtensa: Add loglvl to show_trace() Dmitry Safonov
2019-11-06  3:05 ` [PATCH 43/50] xtensa: Add show_stack_loglvl() Dmitry Safonov
2019-11-06  4:13   ` Max Filippov
2019-11-06  8:15     ` Petr Mladek
2019-11-06 16:06       ` Dmitry Safonov [this message]
2019-11-06 16:44       ` Max Filippov
2019-11-06  3:05 ` [PATCH 44/50] sysrq: Use show_stack_loglvl() Dmitry Safonov
2019-11-06  3:05 ` [PATCH 45/50] x86/amd_gart: Print stacktrace for a leak with KERN_ERR Dmitry Safonov
2019-11-06  3:05 ` [PATCH 46/50] power: Use show_stack_loglvl() Dmitry Safonov
2019-11-06  3:05 ` [PATCH 47/50] kdb: Don't play with console_loglevel Dmitry Safonov
2019-11-06  3:05 ` [PATCH 48/50] sched: Print stack trace with KERN_INFO Dmitry Safonov
2019-11-06  3:05 ` [PATCH 49/50] kernel: Use show_stack_loglvl() Dmitry Safonov
2019-11-06  3:05 ` [PATCH 50/50] kernel: Rename show_stack_loglvl() => show_stack() Dmitry Safonov
2019-11-08 10:08   ` kbuild test robot
     [not found] ` <20191106092039.GT4131@hirez.programming.kicks-ass.net>
     [not found]   ` <10db6fa1-5b17-ebe6-09e0-6335e09e4db8@arista.com>
     [not found]     ` <20191106203440.GH3079@worktop.programming.kicks-ass.net>
     [not found]       ` <20191106232512.GU25745@shell.armlinux.org.uk>
2019-11-07  7:27         ` [PATCH 00/50] Add log level to show_stack() Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=836351a4-581d-325f-862f-99c0c4f98e19@arista.com \
    --to=dima@arista.com \
    --cc=0x7f454c46@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=chris@zankel.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=jcmvbkbc@gmail.com \
    --cc=jslaby@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xtensa@linux-xtensa.org \
    --cc=mingo@kernel.org \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=sergey.senozhatsky@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®