From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
Marc Zyngier <maz@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Kurt Kanzenbach <kurt@linutronix.de>
Subject: [PATCH v7 0/2] Add support for Layerscape external interrupt lines
Date: Thu, 7 Nov 2019 13:21:13 +0100 [thread overview]
Message-ID: <20191107122115.6244-1-linux@rasmusvillemoes.dk> (raw)
In v7, I've tried to change from a custom binding to use
interrupt-map, modelled on the recent addition of the
renesas,rza1-irqc (commits a644ccb819bc and 5e27a314a11f). It's
possible that the interrupt-map parsing code can be factored to a
common helper, but it's a bit hard to generalize from two examples to
know what a good interface would look like.
The interrupt-map-mask is a bit arbitrary. 0xff would likely work just
as well (but I think the ls2088a has 32 external lines, so it has to
be a least 0x1f).
Also, this drops the fsl,bit-reverse property and instead reads the
SCFGREVCR register to determine if bit-reversing is needed.
The dt/bindings patch now comes first in accordance with
Documentation/devicetree/bindings/submitting-patches.txt.
Earlier versions can be found here:
v6: https://lore.kernel.org/lkml/20190923101513.32719-1-kurt@linutronix.de/
v5: https://lore.kernel.org/lkml/20180223210901.23480-1-rasmus.villemoes@prevas.dk/
Rasmus Villemoes (2):
dt/bindings: Add bindings for Layerscape external irqs
irqchip: add support for Layerscape external interrupt lines
.../interrupt-controller/fsl,ls-extirq.txt | 49 +++++
drivers/irqchip/Kconfig | 4 +
drivers/irqchip/Makefile | 1 +
drivers/irqchip/irq-ls-extirq.c | 197 ++++++++++++++++++
4 files changed, 251 insertions(+)
create mode 100644 Documentation/devicetree/bindings/interrupt-controller/fsl,ls-extirq.txt
create mode 100644 drivers/irqchip/irq-ls-extirq.c
--
2.23.0
next reply other threads:[~2019-11-07 12:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 12:21 Rasmus Villemoes [this message]
2019-11-07 12:21 ` [PATCH v7 1/2] dt/bindings: Add bindings for Layerscape external irqs Rasmus Villemoes
2019-11-20 13:21 ` [tip: irq/core] " tip-bot2 for Rasmus Villemoes
2019-11-07 12:21 ` [PATCH v7 2/2] irqchip: add support for Layerscape external interrupt lines Rasmus Villemoes
2019-11-20 13:21 ` [tip: irq/core] irqchip: Add " tip-bot2 for Rasmus Villemoes
2019-11-11 10:24 ` [PATCH v7 0/2] " Marc Zyngier
2019-11-11 10:31 ` Vladimir Oltean
2019-11-12 10:18 ` Rasmus Villemoes
2019-11-12 10:58 ` Marc Zyngier
2019-11-12 11:44 ` Rasmus Villemoes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191107122115.6244-1-linux@rasmusvillemoes.dk \
--to=linux@rasmusvillemoes.dk \
--cc=devicetree@vger.kernel.org \
--cc=jason@lakedaemon.net \
--cc=kurt@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®