[linux-next:master 11698/12822] drivers/misc/vmw_vmci/vmci_driver.c:33:6: sparse: sparse: symbol 'vmci_vsock_cb_host_called' was not declared. Should it be static?

[linux-next:master 11698/12822] drivers/misc/vmw_vmci/vmci_driver.c:33:6: sparse: sparse: symbol 'vmci_vsock_cb_host_called' was not declared. Should it be static?

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   519ead8f6a3215406afc6e56c596388a690f2edc
commit: b1bba80a4376aef34de2b57bfb8834bd095703ed [11698/12822] vsock/vmci: register vmci_transport only when VMCI guest/host are active
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-32-g233d4e1-dirty
        git checkout b1bba80a4376aef34de2b57bfb8834bd095703ed
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

>> drivers/misc/vmw_vmci/vmci_driver.c:33:6: sparse: sparse: symbol 'vmci_vsock_cb_host_called' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

[RFC PATCH linux-next] vsock/vmci: vmci_vsock_cb_host_called can be static

[kbuild test robot]

Fixes: b1bba80a4376 ("vsock/vmci: register vmci_transport only when VMCI guest/host are active")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
 vmci_driver.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/vmw_vmci/vmci_driver.c b/drivers/misc/vmw_vmci/vmci_driver.c
index 95fed4664a2d2..cbb706dabede9 100644
--- a/drivers/misc/vmw_vmci/vmci_driver.c
+++ b/drivers/misc/vmw_vmci/vmci_driver.c
@@ -30,7 +30,7 @@ static bool vmci_host_personality_initialized;
 
 static DEFINE_MUTEX(vmci_vsock_mutex); /* protects vmci_vsock_transport_cb */
 static vmci_vsock_cb vmci_vsock_transport_cb;
-bool vmci_vsock_cb_host_called;
+static bool vmci_vsock_cb_host_called;
 
 /*
  * vmci_get_context_id() - Gets the current context ID.

Re: [RFC PATCH linux-next] vsock/vmci: vmci_vsock_cb_host_called can be static

[Stefano Garzarella]

On Tue, Nov 19, 2019 at 12:56:15AM +0800, kbuild test robot wrote:
> 
> Fixes: b1bba80a4376 ("vsock/vmci: register vmci_transport only when VMCI guest/host are active")
> Signed-off-by: kbuild test robot <lkp@intel.com>
> ---
>  vmci_driver.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/vmw_vmci/vmci_driver.c b/drivers/misc/vmw_vmci/vmci_driver.c
> index 95fed4664a2d2..cbb706dabede9 100644
> --- a/drivers/misc/vmw_vmci/vmci_driver.c
> +++ b/drivers/misc/vmw_vmci/vmci_driver.c
> @@ -30,7 +30,7 @@ static bool vmci_host_personality_initialized;
>  
>  static DEFINE_MUTEX(vmci_vsock_mutex); /* protects vmci_vsock_transport_cb */
>  static vmci_vsock_cb vmci_vsock_transport_cb;
> -bool vmci_vsock_cb_host_called;
> +static bool vmci_vsock_cb_host_called;
>  
>  /*
>   * vmci_get_context_id() - Gets the current context ID.
> 

My fault!

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>