From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Colin King <colin.king@canonical.com>
Cc: Ariel Elior <aelior@marvell.com>,
GR-everest-linux-l2@marvell.com,
"David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] qed: remove redundant assignments to rc
Date: Fri, 22 Nov 2019 16:40:41 -0800 [thread overview]
Message-ID: <20191122164041.1819414b@cakuba.netronome.com> (raw)
In-Reply-To: <20191122233839.110620-1-colin.king@canonical.com>
On Fri, 22 Nov 2019 23:38:39 +0000, Colin King wrote:
> diff --git a/drivers/net/ethernet/qlogic/qed/qed_sp_commands.c b/drivers/net/ethernet/qlogic/qed/qed_sp_commands.c
> index 7e0b795230b2..12fc5f3b5cb4 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_sp_commands.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_sp_commands.c
> @@ -331,7 +331,7 @@ int qed_sp_pf_start(struct qed_hwfn *p_hwfn,
> u8 sb_index = p_hwfn->p_eq->eq_sb_index;
> struct qed_spq_entry *p_ent = NULL;
> struct qed_sp_init_data init_data;
> - int rc = -EINVAL;
> + int rc;
> u8 page_cnt, i;
>
> /* update initial eq producer */
I like the clean up but, the variables here are ordered longest
to shortest, please don't break people's coding style :(
prev parent reply other threads:[~2019-11-23 0:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-22 23:38 Colin King
2019-11-23 0:40 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191122164041.1819414b@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=GR-everest-linux-l2@marvell.com \
--cc=aelior@marvell.com \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®