From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Alexander Potapenko <glider@google.com>,
Tomas Bortoli <tomasbortoli@gmail.com>,
Johan Hedberg <johan.hedberg@gmail.com>,
Bluez mailing list <linux-bluetooth@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
syzkaller <syzkaller@googlegroups.com>,
syzbot+a0d209a4676664613e76@syzkaller.appspotmail.com
Subject: Re: [PATCH] Fix invalid-free in bcsp_close()
Date: Tue, 26 Nov 2019 09:12:58 +0100 [thread overview]
Message-ID: <20191126081258.GA1233188@kroah.com> (raw)
In-Reply-To: <8376D008-EA21-49EA-AF5A-DDDCB179EAC5@holtmann.org>
On Tue, Nov 26, 2019 at 07:18:46AM +0100, Marcel Holtmann wrote:
> Hi Alexander,
>
> >>> Syzbot reported an invalid-free that I introduced fixing a memleak.
> >>>
> >>> bcsp_recv() also frees bcsp->rx_skb but never nullifies its value.
> >>> Nullify bcsp->rx_skb every time it is freed.
> >>>
> >>> Signed-off-by: Tomas Bortoli <tomasbortoli@gmail.com>
> >>> Reported-by: syzbot+a0d209a4676664613e76@syzkaller.appspotmail.com
> >>> ---
> >>> drivers/bluetooth/hci_bcsp.c | 3 +++
> >>> 1 file changed, 3 insertions(+)
> >>
> >> patch has been applied to bluetooth-next tree.
> > I believe this bug requires stable tags, as it can potentially provide
> > an arbitrary write (via __skb_unlink) and is triggerable locally with
> > user privileges.
>
> I do not have a reproducer for it, but if you do, feel free to propose it for -stable inclusion.
Now queued up, thanks.
greg k-h
prev parent reply other threads:[~2019-11-26 8:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 15:42 KASAN: invalid-free in skb_free_head syzbot
2019-11-01 20:42 ` [PATCH] Fix invalid-free in bcsp_close() Tomas Bortoli
2019-11-04 14:19 ` Marcel Holtmann
2019-11-25 12:40 ` Alexander Potapenko
2019-11-26 6:18 ` Marcel Holtmann
2019-11-26 8:12 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191126081258.GA1233188@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=glider@google.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=syzbot+a0d209a4676664613e76@syzkaller.appspotmail.com \
--cc=syzkaller@googlegroups.com \
--cc=tomasbortoli@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome