* [PATCH] drm/dp_mst: Fix build on systems with STACKTRACE_SUPPORT=n
@ 2019-12-02 13:36 Guenter Roeck
2019-12-02 15:20 ` Geert Uytterhoeven
0 siblings, 1 reply; 5+ messages in thread
From: Guenter Roeck @ 2019-12-02 13:36 UTC (permalink / raw)
To: Maarten Lankhorst
Cc: Maxime Ripard, Sean Paul, David Airlie, Daniel Vetter, dri-devel,
linux-kernel, Guenter Roeck, Lyude Paul
On systems with STACKTRACE_SUPPORT=n, we get:
WARNING: unmet direct dependencies detected for STACKTRACE
Depends on [n]: STACKTRACE_SUPPORT
Selected by [y]:
- STACKDEPOT [=y]
and build errors such as:
m68k-linux-ld: kernel/stacktrace.o: in function `stack_trace_save':
(.text+0x11c): undefined reference to `save_stack_trace'
Add the missing deendency on STACKTRACE_SUPPORT.
Fixes: 12a280c72868 ("drm/dp_mst: Add topology ref history tracking for debugging")
Cc: Lyude Paul <lyude@redhat.com>
Cc: Sean Paul <sean@poorly.run>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
drivers/gpu/drm/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
index 1168351267fd..bfdadc3667e0 100644
--- a/drivers/gpu/drm/Kconfig
+++ b/drivers/gpu/drm/Kconfig
@@ -95,6 +95,7 @@ config DRM_KMS_FB_HELPER
config DRM_DEBUG_DP_MST_TOPOLOGY_REFS
bool "Enable refcount backtrace history in the DP MST helpers"
+ depends on STACKTRACE_SUPPORT
select STACKDEPOT
depends on DRM_KMS_HELPER
depends on DEBUG_KERNEL
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/dp_mst: Fix build on systems with STACKTRACE_SUPPORT=n
2019-12-02 13:36 [PATCH] drm/dp_mst: Fix build on systems with STACKTRACE_SUPPORT=n Guenter Roeck
@ 2019-12-02 15:20 ` Geert Uytterhoeven
2019-12-02 18:49 ` Lyude Paul
0 siblings, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2019-12-02 15:20 UTC (permalink / raw)
To: Guenter Roeck
Cc: Maarten Lankhorst, Maxime Ripard, Sean Paul, David Airlie,
Daniel Vetter, DRI Development, Linux Kernel Mailing List,
Lyude Paul
On Mon, Dec 2, 2019 at 2:41 PM Guenter Roeck <linux@roeck-us.net> wrote:
> On systems with STACKTRACE_SUPPORT=n, we get:
>
> WARNING: unmet direct dependencies detected for STACKTRACE
> Depends on [n]: STACKTRACE_SUPPORT
> Selected by [y]:
> - STACKDEPOT [=y]
>
> and build errors such as:
>
> m68k-linux-ld: kernel/stacktrace.o: in function `stack_trace_save':
> (.text+0x11c): undefined reference to `save_stack_trace'
>
> Add the missing deendency on STACKTRACE_SUPPORT.
>
> Fixes: 12a280c72868 ("drm/dp_mst: Add topology ref history tracking for debugging")
> Cc: Lyude Paul <lyude@redhat.com>
> Cc: Sean Paul <sean@poorly.run>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/dp_mst: Fix build on systems with STACKTRACE_SUPPORT=n
2019-12-02 15:20 ` Geert Uytterhoeven
@ 2019-12-02 18:49 ` Lyude Paul
2019-12-03 9:33 ` Daniel Vetter
0 siblings, 1 reply; 5+ messages in thread
From: Lyude Paul @ 2019-12-02 18:49 UTC (permalink / raw)
To: Geert Uytterhoeven, Guenter Roeck
Cc: Maarten Lankhorst, Maxime Ripard, Sean Paul, David Airlie,
Daniel Vetter, DRI Development, Linux Kernel Mailing List
Reviewed-by: Lyude Paul <lyude@redhat.com>
I'll go ahead and push this to drm-misc-next, thanks!
On Mon, 2019-12-02 at 16:20 +0100, Geert Uytterhoeven wrote:
> On Mon, Dec 2, 2019 at 2:41 PM Guenter Roeck <linux@roeck-us.net> wrote:
> > On systems with STACKTRACE_SUPPORT=n, we get:
> >
> > WARNING: unmet direct dependencies detected for STACKTRACE
> > Depends on [n]: STACKTRACE_SUPPORT
> > Selected by [y]:
> > - STACKDEPOT [=y]
> >
> > and build errors such as:
> >
> > m68k-linux-ld: kernel/stacktrace.o: in function `stack_trace_save':
> > (.text+0x11c): undefined reference to `save_stack_trace'
> >
> > Add the missing deendency on STACKTRACE_SUPPORT.
> >
> > Fixes: 12a280c72868 ("drm/dp_mst: Add topology ref history tracking for
> > debugging")
> > Cc: Lyude Paul <lyude@redhat.com>
> > Cc: Sean Paul <sean@poorly.run>
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>
> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
> Gr{oetje,eeting}s,
>
> Geert
>
--
Cheers,
Lyude Paul
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/dp_mst: Fix build on systems with STACKTRACE_SUPPORT=n
2019-12-02 18:49 ` Lyude Paul
@ 2019-12-03 9:33 ` Daniel Vetter
2019-12-03 21:30 ` Lyude Paul
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Vetter @ 2019-12-03 9:33 UTC (permalink / raw)
To: Lyude Paul
Cc: Geert Uytterhoeven, Guenter Roeck, Maarten Lankhorst,
Maxime Ripard, Sean Paul, David Airlie, Daniel Vetter,
DRI Development, Linux Kernel Mailing List
On Mon, Dec 02, 2019 at 01:49:47PM -0500, Lyude Paul wrote:
> Reviewed-by: Lyude Paul <lyude@redhat.com>
>
> I'll go ahead and push this to drm-misc-next, thanks!
drm-misc-next-fixes since it's in the merge window. drm-misc-next is for
5.6 already.
-Daniel
>
> On Mon, 2019-12-02 at 16:20 +0100, Geert Uytterhoeven wrote:
> > On Mon, Dec 2, 2019 at 2:41 PM Guenter Roeck <linux@roeck-us.net> wrote:
> > > On systems with STACKTRACE_SUPPORT=n, we get:
> > >
> > > WARNING: unmet direct dependencies detected for STACKTRACE
> > > Depends on [n]: STACKTRACE_SUPPORT
> > > Selected by [y]:
> > > - STACKDEPOT [=y]
> > >
> > > and build errors such as:
> > >
> > > m68k-linux-ld: kernel/stacktrace.o: in function `stack_trace_save':
> > > (.text+0x11c): undefined reference to `save_stack_trace'
> > >
> > > Add the missing deendency on STACKTRACE_SUPPORT.
> > >
> > > Fixes: 12a280c72868 ("drm/dp_mst: Add topology ref history tracking for
> > > debugging")
> > > Cc: Lyude Paul <lyude@redhat.com>
> > > Cc: Sean Paul <sean@poorly.run>
> > > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> >
> > Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
> >
> > Gr{oetje,eeting}s,
> >
> > Geert
> >
> --
> Cheers,
> Lyude Paul
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/dp_mst: Fix build on systems with STACKTRACE_SUPPORT=n
2019-12-03 9:33 ` Daniel Vetter
@ 2019-12-03 21:30 ` Lyude Paul
0 siblings, 0 replies; 5+ messages in thread
From: Lyude Paul @ 2019-12-03 21:30 UTC (permalink / raw)
To: Daniel Vetter
Cc: Geert Uytterhoeven, Guenter Roeck, Maarten Lankhorst,
Maxime Ripard, Sean Paul, David Airlie, DRI Development,
Linux Kernel Mailing List
On Tue, 2019-12-03 at 10:33 +0100, Daniel Vetter wrote:
> On Mon, Dec 02, 2019 at 01:49:47PM -0500, Lyude Paul wrote:
> > Reviewed-by: Lyude Paul <lyude@redhat.com>
> >
> > I'll go ahead and push this to drm-misc-next, thanks!
>
> drm-misc-next-fixes since it's in the merge window. drm-misc-next is for
> 5.6 already.
> -Daniel
Ahh, that explains things :). Pushed, thanks for the patches!
>
> > On Mon, 2019-12-02 at 16:20 +0100, Geert Uytterhoeven wrote:
> > > On Mon, Dec 2, 2019 at 2:41 PM Guenter Roeck <linux@roeck-us.net> wrote:
> > > > On systems with STACKTRACE_SUPPORT=n, we get:
> > > >
> > > > WARNING: unmet direct dependencies detected for STACKTRACE
> > > > Depends on [n]: STACKTRACE_SUPPORT
> > > > Selected by [y]:
> > > > - STACKDEPOT [=y]
> > > >
> > > > and build errors such as:
> > > >
> > > > m68k-linux-ld: kernel/stacktrace.o: in function `stack_trace_save':
> > > > (.text+0x11c): undefined reference to `save_stack_trace'
> > > >
> > > > Add the missing deendency on STACKTRACE_SUPPORT.
> > > >
> > > > Fixes: 12a280c72868 ("drm/dp_mst: Add topology ref history tracking
> > > > for
> > > > debugging")
> > > > Cc: Lyude Paul <lyude@redhat.com>
> > > > Cc: Sean Paul <sean@poorly.run>
> > > > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> > >
> > > Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > >
> > > Gr{oetje,eeting}s,
> > >
> > > Geert
> > >
> > --
> > Cheers,
> > Lyude Paul
> >
--
Cheers,
Lyude Paul
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-12-03 21:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-02 13:36 [PATCH] drm/dp_mst: Fix build on systems with STACKTRACE_SUPPORT=n Guenter Roeck
2019-12-02 15:20 ` Geert Uytterhoeven
2019-12-02 18:49 ` Lyude Paul
2019-12-03 9:33 ` Daniel Vetter
2019-12-03 21:30 ` Lyude Paul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®