* [PATCH] mtd: spi-nor: Fix the write Status Register on micron flashes [not found] <00cf6eab-9798-b0e9-e4a2-5b2f8374b698@huawei.com> @ 2019-12-03 14:16 ` Tudor.Ambarus 2019-12-03 14:50 ` [PATCH v2] mtd: spi-nor: Fix the writing of the " Tudor.Ambarus 0 siblings, 1 reply; 4+ messages in thread From: Tudor.Ambarus @ 2019-12-03 14:16 UTC (permalink / raw) To: john.garry, vigneshr, richard, miquel.raynal Cc: linux-mtd, linux-kernel, Tudor.Ambarus From: Tudor Ambarus <tudor.ambarus@microchip.com> Micron flashes do not support 16 bit writes on the Status Register. According to micron datasheets, when using the Write Status Register (01h) command, the chip select should be driven LOW and held LOW until the eighth bit of the last data byte has been latched in, after which it must be driven HIGH. If CS is not driven HIGH, the command is not executed, flag status register error bits are not set, and the write enable latch remains set to 1. This fixes the lock operations on micron flashes. Reported-by: John Garry <john.garry@huawei.com> Fixes: 39d1e3340c73 ("mtd: spi-nor: Fix clearing of QE bit on lock()/unlock()") Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com> --- drivers/mtd/spi-nor/spi-nor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c index f1490c7b5cb9..7e41493f69d8 100644 --- a/drivers/mtd/spi-nor/spi-nor.c +++ b/drivers/mtd/spi-nor/spi-nor.c @@ -4607,6 +4607,7 @@ static void sst_set_default_init(struct spi_nor *nor) static void st_micron_set_default_init(struct spi_nor *nor) { nor->flags |= SNOR_F_HAS_LOCK; + nor->flags &= ~SNOR_F_HAS_16BIT_SR; nor->params.quad_enable = NULL; nor->params.set_4byte = st_micron_set_4byte; } -- 2.14.5 ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] mtd: spi-nor: Fix the writing of the Status Register on micron flashes 2019-12-03 14:16 ` [PATCH] mtd: spi-nor: Fix the write Status Register on micron flashes Tudor.Ambarus @ 2019-12-03 14:50 ` Tudor.Ambarus 2019-12-04 10:18 ` John Garry 2020-01-09 19:14 ` Miquel Raynal 0 siblings, 2 replies; 4+ messages in thread From: Tudor.Ambarus @ 2019-12-03 14:50 UTC (permalink / raw) To: john.garry, vigneshr, richard, miquel.raynal Cc: linux-mtd, linux-kernel, Tudor.Ambarus From: Tudor Ambarus <tudor.ambarus@microchip.com> Micron flashes do not support 16 bit writes on the Status Register. According to micron datasheets, when using the Write Status Register (01h) command, the chip select should be driven LOW and held LOW until the eighth bit of the last data byte has been latched in, after which it must be driven HIGH. If CS is not driven HIGH, the command is not executed, flag status register error bits are not set, and the write enable latch remains set to 1. This fixes the lock operations on micron flashes. Reported-by: John Garry <john.garry@huawei.com> Fixes: 39d1e3340c73 ("mtd: spi-nor: Fix clearing of QE bit on lock()/unlock()") Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com> --- v2: reword commit subject drivers/mtd/spi-nor/spi-nor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c index f1490c7b5cb9..7e41493f69d8 100644 --- a/drivers/mtd/spi-nor/spi-nor.c +++ b/drivers/mtd/spi-nor/spi-nor.c @@ -4607,6 +4607,7 @@ static void sst_set_default_init(struct spi_nor *nor) static void st_micron_set_default_init(struct spi_nor *nor) { nor->flags |= SNOR_F_HAS_LOCK; + nor->flags &= ~SNOR_F_HAS_16BIT_SR; nor->params.quad_enable = NULL; nor->params.set_4byte = st_micron_set_4byte; } -- 2.14.5 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] mtd: spi-nor: Fix the writing of the Status Register on micron flashes 2019-12-03 14:50 ` [PATCH v2] mtd: spi-nor: Fix the writing of the " Tudor.Ambarus @ 2019-12-04 10:18 ` John Garry 2020-01-09 19:14 ` Miquel Raynal 1 sibling, 0 replies; 4+ messages in thread From: John Garry @ 2019-12-04 10:18 UTC (permalink / raw) To: Tudor.Ambarus, vigneshr, richard, miquel.raynal Cc: linux-mtd, linux-kernel, chenxiang, fengsheng5 On 03/12/2019 14:50, Tudor.Ambarus@microchip.com wrote: > From: Tudor Ambarus <tudor.ambarus@microchip.com> > > Micron flashes do not support 16 bit writes on the Status Register. > According to micron datasheets, when using the Write Status Register > (01h) command, the chip select should be driven LOW and held LOW until > the eighth bit of the last data byte has been latched in, after which > it must be driven HIGH. If CS is not driven HIGH, the command is not > executed, flag status register error bits are not set, and the write enable > latch remains set to 1. This fixes the lock operations on micron flashes. > > Reported-by: John Garry <john.garry@huawei.com> > Fixes: 39d1e3340c73 ("mtd: spi-nor: Fix clearing of QE bit on lock()/unlock()") > Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com> Thanks, Tested-by: John Garry <john.garry@huawei.com> > --- > v2: reword commit subject > > drivers/mtd/spi-nor/spi-nor.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c > index f1490c7b5cb9..7e41493f69d8 100644 > --- a/drivers/mtd/spi-nor/spi-nor.c > +++ b/drivers/mtd/spi-nor/spi-nor.c > @@ -4607,6 +4607,7 @@ static void sst_set_default_init(struct spi_nor *nor) > static void st_micron_set_default_init(struct spi_nor *nor) > { > nor->flags |= SNOR_F_HAS_LOCK; > + nor->flags &= ~SNOR_F_HAS_16BIT_SR; > nor->params.quad_enable = NULL; > nor->params.set_4byte = st_micron_set_4byte; > } > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] mtd: spi-nor: Fix the writing of the Status Register on micron flashes 2019-12-03 14:50 ` [PATCH v2] mtd: spi-nor: Fix the writing of the " Tudor.Ambarus 2019-12-04 10:18 ` John Garry @ 2020-01-09 19:14 ` Miquel Raynal 1 sibling, 0 replies; 4+ messages in thread From: Miquel Raynal @ 2020-01-09 19:14 UTC (permalink / raw) To: Tudor.Ambarus, john.garry, vigneshr, richard, miquel.raynal Cc: linux-mtd, linux-kernel On Tue, 2019-12-03 at 14:50:01 UTC, wrote: > From: Tudor Ambarus <tudor.ambarus@microchip.com> > > Micron flashes do not support 16 bit writes on the Status Register. > According to micron datasheets, when using the Write Status Register > (01h) command, the chip select should be driven LOW and held LOW until > the eighth bit of the last data byte has been latched in, after which > it must be driven HIGH. If CS is not driven HIGH, the command is not > executed, flag status register error bits are not set, and the write enable > latch remains set to 1. This fixes the lock operations on micron flashes. > > Reported-by: John Garry <john.garry@huawei.com> > Fixes: 39d1e3340c73 ("mtd: spi-nor: Fix clearing of QE bit on lock()/unlock()") > Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com> > Tested-by: John Garry <john.garry@huawei.com> Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/fixes, thanks. Miquel ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-01-09 19:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <00cf6eab-9798-b0e9-e4a2-5b2f8374b698@huawei.com>
2019-12-03 14:16 ` [PATCH] mtd: spi-nor: Fix the write Status Register on micron flashes Tudor.Ambarus
2019-12-03 14:50 ` [PATCH v2] mtd: spi-nor: Fix the writing of the " Tudor.Ambarus
2019-12-04 10:18 ` John Garry
2020-01-09 19:14 ` Miquel Raynal
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®