* [PATCH v2] gpio: pca953x: Don't hardcode irq trigger type
@ 2019-12-09 6:27 Vignesh Raghavendra
2019-12-11 9:47 ` Bartosz Golaszewski
0 siblings, 1 reply; 2+ messages in thread
From: Vignesh Raghavendra @ 2019-12-09 6:27 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski
Cc: linux-gpio, linux-kernel, Vignesh Raghavendra, Grygorii Strashko
Don't hardcode irq trigger to IRQF_TRIGGER_LOW while registering IRQ
handler. IRQ/platform core will take care of setting appropriate trigger
type.
Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
---
v2:
Drop explicit call to irq_get_trigger_type() as this is take care of in core
code.
drivers/gpio/gpio-pca953x.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
index 6652bee01966..40e48f7d83bb 100644
--- a/drivers/gpio/gpio-pca953x.c
+++ b/drivers/gpio/gpio-pca953x.c
@@ -770,8 +770,7 @@ static int pca953x_irq_setup(struct pca953x_chip *chip, int irq_base)
ret = devm_request_threaded_irq(&client->dev, client->irq,
NULL, pca953x_irq_handler,
- IRQF_TRIGGER_LOW | IRQF_ONESHOT |
- IRQF_SHARED,
+ IRQF_ONESHOT | IRQF_SHARED,
dev_name(&client->dev), chip);
if (ret) {
dev_err(&client->dev, "failed to request irq %d\n",
--
2.24.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH v2] gpio: pca953x: Don't hardcode irq trigger type
2019-12-09 6:27 [PATCH v2] gpio: pca953x: Don't hardcode irq trigger type Vignesh Raghavendra
@ 2019-12-11 9:47 ` Bartosz Golaszewski
0 siblings, 0 replies; 2+ messages in thread
From: Bartosz Golaszewski @ 2019-12-11 9:47 UTC (permalink / raw)
To: Vignesh Raghavendra; +Cc: Linus Walleij, linux-gpio, LKML, Grygorii Strashko
pon., 9 gru 2019 o 07:27 Vignesh Raghavendra <vigneshr@ti.com> napisał(a):
>
> Don't hardcode irq trigger to IRQF_TRIGGER_LOW while registering IRQ
> handler. IRQ/platform core will take care of setting appropriate trigger
> type.
>
> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
> ---
> v2:
> Drop explicit call to irq_get_trigger_type() as this is take care of in core
> code.
>
> drivers/gpio/gpio-pca953x.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
> index 6652bee01966..40e48f7d83bb 100644
> --- a/drivers/gpio/gpio-pca953x.c
> +++ b/drivers/gpio/gpio-pca953x.c
> @@ -770,8 +770,7 @@ static int pca953x_irq_setup(struct pca953x_chip *chip, int irq_base)
>
> ret = devm_request_threaded_irq(&client->dev, client->irq,
> NULL, pca953x_irq_handler,
> - IRQF_TRIGGER_LOW | IRQF_ONESHOT |
> - IRQF_SHARED,
> + IRQF_ONESHOT | IRQF_SHARED,
> dev_name(&client->dev), chip);
> if (ret) {
> dev_err(&client->dev, "failed to request irq %d\n",
> --
> 2.24.0
>
Patch applied, thanks!
Bartosz
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-11 9:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-09 6:27 [PATCH v2] gpio: pca953x: Don't hardcode irq trigger type Vignesh Raghavendra
2019-12-11 9:47 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®