* [PATCH][next] drm/i915/selftests: fix uninitialized variable sum when summing up values
@ 2019-12-10 14:32 Colin King
2019-12-10 14:34 ` Chris Wilson
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2019-12-10 14:32 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, David Airlie,
Daniel Vetter, Matthew Auld, Chris Wilson, intel-gfx, dri-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Currently the variable sum is not uninitialized and hence will cause an
incorrect result in the summation values. Fix this by initializing
sum to the first item in the summation.
Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: 3c7a44bbbfa7 ("drm/i915/selftests: Perform some basic cycle counting of MI ops")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpu/drm/i915/gt/selftest_engine_cs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/selftest_engine_cs.c b/drivers/gpu/drm/i915/gt/selftest_engine_cs.c
index 761d81f4bd68..f88e445a1cae 100644
--- a/drivers/gpu/drm/i915/gt/selftest_engine_cs.c
+++ b/drivers/gpu/drm/i915/gt/selftest_engine_cs.c
@@ -108,7 +108,7 @@ static u32 trifilter(u32 *a)
sort(a, COUNT, sizeof(*a), cmp_u32, NULL);
- sum += mul_u32_u32(a[2], 2);
+ sum = mul_u32_u32(a[2], 2);
sum += a[1];
sum += a[3];
--
2.24.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH][next] drm/i915/selftests: fix uninitialized variable sum when summing up values
2019-12-10 14:32 [PATCH][next] drm/i915/selftests: fix uninitialized variable sum when summing up values Colin King
@ 2019-12-10 14:34 ` Chris Wilson
0 siblings, 0 replies; 2+ messages in thread
From: Chris Wilson @ 2019-12-10 14:34 UTC (permalink / raw)
To: Colin King, Daniel Vetter, David Airlie, Jani Nikula,
Joonas Lahtinen, Matthew Auld, Rodrigo Vivi, dri-devel,
intel-gfx
Cc: kernel-janitors, linux-kernel
Quoting Colin King (2019-12-10 14:32:05)
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently the variable sum is not uninitialized and hence will cause an
> incorrect result in the summation values. Fix this by initializing
> sum to the first item in the summation.
>
> Addresses-Coverity: ("Uninitialized scalar variable")
> Fixes: 3c7a44bbbfa7 ("drm/i915/selftests: Perform some basic cycle counting of MI ops")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/gpu/drm/i915/gt/selftest_engine_cs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/selftest_engine_cs.c b/drivers/gpu/drm/i915/gt/selftest_engine_cs.c
> index 761d81f4bd68..f88e445a1cae 100644
> --- a/drivers/gpu/drm/i915/gt/selftest_engine_cs.c
> +++ b/drivers/gpu/drm/i915/gt/selftest_engine_cs.c
> @@ -108,7 +108,7 @@ static u32 trifilter(u32 *a)
>
> sort(a, COUNT, sizeof(*a), cmp_u32, NULL);
>
> - sum += mul_u32_u32(a[2], 2);
> + sum = mul_u32_u32(a[2], 2);
/o\
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-10 14:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-10 14:32 [PATCH][next] drm/i915/selftests: fix uninitialized variable sum when summing up values Colin King
2019-12-10 14:34 ` Chris Wilson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®