* [PATCH] lib: crc64: include <linux/crc64.h> for 'crc64_be'
@ 2019-12-17 11:26 Ben Dooks (Codethink)
2019-12-17 11:49 ` Coly Li
2019-12-17 11:57 ` Andy Shevchenko
0 siblings, 2 replies; 4+ messages in thread
From: Ben Dooks (Codethink) @ 2019-12-17 11:26 UTC (permalink / raw)
To: ben.dooks; +Cc: Coly Li, Andy Shevchenko, linux-kernel
The crc64_be() is declared in <linux/crc64.h> so include
this where the symbol is defined to avoid the following
warning:
lib/crc64.c:43:12: warning: symbol 'crc64_be' was not declared. Should it be static?
Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
---
Cc: Coly Li <colyli@suse.de>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org
---
lib/crc64.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/crc64.c b/lib/crc64.c
index 0ef8ae6ac047..f8928ce28280 100644
--- a/lib/crc64.c
+++ b/lib/crc64.c
@@ -28,6 +28,7 @@
#include <linux/module.h>
#include <linux/types.h>
+#include <linux/crc64.h>
#include "crc64table.h"
MODULE_DESCRIPTION("CRC64 calculations");
--
2.24.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] lib: crc64: include <linux/crc64.h> for 'crc64_be'
2019-12-17 11:26 [PATCH] lib: crc64: include <linux/crc64.h> for 'crc64_be' Ben Dooks (Codethink)
@ 2019-12-17 11:49 ` Coly Li
2019-12-17 11:57 ` Andy Shevchenko
1 sibling, 0 replies; 4+ messages in thread
From: Coly Li @ 2019-12-17 11:49 UTC (permalink / raw)
To: Ben Dooks (Codethink); +Cc: Andy Shevchenko, linux-kernel
On 2019/12/17 7:26 下午, Ben Dooks (Codethink) wrote:
> The crc64_be() is declared in <linux/crc64.h> so include
> this where the symbol is defined to avoid the following
> warning:
>
> lib/crc64.c:43:12: warning: symbol 'crc64_be' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
It is good to me. Added to my for-test patches. Thanks.
Coly Li
> ---
> Cc: Coly Li <colyli@suse.de>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: linux-kernel@vger.kernel.org
> ---
> lib/crc64.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/crc64.c b/lib/crc64.c
> index 0ef8ae6ac047..f8928ce28280 100644
> --- a/lib/crc64.c
> +++ b/lib/crc64.c
> @@ -28,6 +28,7 @@
>
> #include <linux/module.h>
> #include <linux/types.h>
> +#include <linux/crc64.h>
> #include "crc64table.h"
>
> MODULE_DESCRIPTION("CRC64 calculations");
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] lib: crc64: include <linux/crc64.h> for 'crc64_be'
2019-12-17 11:26 [PATCH] lib: crc64: include <linux/crc64.h> for 'crc64_be' Ben Dooks (Codethink)
2019-12-17 11:49 ` Coly Li
@ 2019-12-17 11:57 ` Andy Shevchenko
2019-12-17 11:58 ` Andy Shevchenko
1 sibling, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2019-12-17 11:57 UTC (permalink / raw)
To: Ben Dooks (Codethink); +Cc: Coly Li, linux-kernel
On Tue, Dec 17, 2019 at 11:26:33AM +0000, Ben Dooks (Codethink) wrote:
> The crc64_be() is declared in <linux/crc64.h> so include
> this where the symbol is defined to avoid the following
> warning:
>
> lib/crc64.c:43:12: warning: symbol 'crc64_be' was not declared. Should it be static?
Thanks!
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
> ---
> Cc: Coly Li <colyli@suse.de>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: linux-kernel@vger.kernel.org
> ---
> lib/crc64.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/crc64.c b/lib/crc64.c
> index 0ef8ae6ac047..f8928ce28280 100644
> --- a/lib/crc64.c
> +++ b/lib/crc64.c
> @@ -28,6 +28,7 @@
>
> #include <linux/module.h>
> #include <linux/types.h>
> +#include <linux/crc64.h>
> #include "crc64table.h"
>
> MODULE_DESCRIPTION("CRC64 calculations");
> --
> 2.24.0
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] lib: crc64: include <linux/crc64.h> for 'crc64_be'
2019-12-17 11:57 ` Andy Shevchenko
@ 2019-12-17 11:58 ` Andy Shevchenko
0 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2019-12-17 11:58 UTC (permalink / raw)
To: Ben Dooks (Codethink); +Cc: Coly Li, linux-kernel
On Tue, Dec 17, 2019 at 01:57:03PM +0200, Andy Shevchenko wrote:
> On Tue, Dec 17, 2019 at 11:26:33AM +0000, Ben Dooks (Codethink) wrote:
> > The crc64_be() is declared in <linux/crc64.h> so include
> > this where the symbol is defined to avoid the following
> > warning:
> >
> > lib/crc64.c:43:12: warning: symbol 'crc64_be' was not declared. Should it be static?
>
> Thanks!
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Sorry, one nit to be addressed...
> > Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
> > ---
> > Cc: Coly Li <colyli@suse.de>
> > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Cc: linux-kernel@vger.kernel.org
> > ---
> > lib/crc64.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/lib/crc64.c b/lib/crc64.c
> > index 0ef8ae6ac047..f8928ce28280 100644
> > --- a/lib/crc64.c
> > +++ b/lib/crc64.c
> > @@ -28,6 +28,7 @@
> >
> > #include <linux/module.h>
> > #include <linux/types.h>
> > +#include <linux/crc64.h>
May we preserve ordering, i.e. it should be first header in the block.
> > #include "crc64table.h"
> >
> > MODULE_DESCRIPTION("CRC64 calculations");
> > --
> > 2.24.0
> >
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-12-17 11:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-17 11:26 [PATCH] lib: crc64: include <linux/crc64.h> for 'crc64_be' Ben Dooks (Codethink)
2019-12-17 11:49 ` Coly Li
2019-12-17 11:57 ` Andy Shevchenko
2019-12-17 11:58 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®