* [PATCH 4/4] Staging: vc04_services: Fix checkpatch.pl error
@ 2019-12-20 5:14 Simran Sandhu
2019-12-20 6:20 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Simran Sandhu @ 2019-12-20 5:14 UTC (permalink / raw)
To: nsaenzjulienne
Cc: gregkh, f.fainelli, rjui, sbranden, bcm-kernel-feedback-list,
tiwai, wahrenst, linux-rpi-kernel, linux-arm-kernel, devel,
linux-kernel
CHECKPATH ERROR: Alignment should match open parenthesis was fixed by entroducing tabs and spaces on the location
drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c:349
Signed-off-by: Simran Sandhu <f20171454@hyderabad.bits-pilani.ac.in>
---
drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c
index 33485184a98a..c3ce6796abce 100644
--- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c
+++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c
@@ -346,7 +346,7 @@ int snd_bcm2835_new_pcm(struct bcm2835_chip *chip, const char *name,
&snd_bcm2835_playback_ops);
snd_pcm_set_managed_buffer_all(pcm, SNDRV_DMA_TYPE_DEV,
- chip->card->dev, 128 * 1024, 128 * 1024);
+ chip->card->dev, 128 * 1024, 128 * 1024);
if (spdif)
chip->pcm_spdif = pcm;
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 4/4] Staging: vc04_services: Fix checkpatch.pl error
2019-12-20 5:14 [PATCH 4/4] Staging: vc04_services: Fix checkpatch.pl error Simran Sandhu
@ 2019-12-20 6:20 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2019-12-20 6:20 UTC (permalink / raw)
To: Simran Sandhu
Cc: nsaenzjulienne, devel, f.fainelli, sbranden, tiwai, linux-kernel,
bcm-kernel-feedback-list, wahrenst, rjui, linux-arm-kernel,
linux-rpi-kernel
On Fri, Dec 20, 2019 at 10:44:14AM +0530, Simran Sandhu wrote:
> CHECKPATH ERROR: Alignment should match open parenthesis was fixed by entroducing tabs and spaces on the location
> drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c:349
That is a list of a checkpatch error, but does not say what you did. Or
if it does, it is not properly linewrapped :(
>
> Signed-off-by: Simran Sandhu <f20171454@hyderabad.bits-pilani.ac.in>
> ---
> drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
And where are patches 1-3 of this series?
Please fix up and resend the whole series.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-20 6:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-20 5:14 [PATCH 4/4] Staging: vc04_services: Fix checkpatch.pl error Simran Sandhu
2019-12-20 6:20 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®