From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
davem@davemloft.net
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>,
Antoine Tenart <antoine.tenart@bootlin.com>
Subject: [PATCH net] of: mdio: mark stub of_mdiobus_child_is_phy as inline
Date: Mon, 23 Dec 2019 14:24:43 +0100 [thread overview]
Message-ID: <20191223132443.115540-1-Jason@zx2c4.com> (raw)
The of_mdiobus_child_is_phy function was recently exported, with a stub
fallback added to simply return false as a static function. The inline
specifier was left out, leading to build time errors:
In file included from linux/include/linux/fs_enet_pd.h:21,
from linux/arch/powerpc/sysdev/fsl_soc.c:26:
linux/include/linux/of_mdio.h:58:13: error: ‘of_mdiobus_child_is_phy’ defined but not used [-Werror=unused-function]
58 | static bool of_mdiobus_child_is_phy(struct device_node *child)
| ^~~~~~~~~~
This commit simply adds the missing inline keyboard.
Fixes: 0aa4d016c043 ("of: mdio: export of_mdiobus_child_is_phy")
Cc: Antoine Tenart <antoine.tenart@bootlin.com>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
---
include/linux/of_mdio.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/of_mdio.h b/include/linux/of_mdio.h
index 79bc82e30c02..491a2b7e77c1 100644
--- a/include/linux/of_mdio.h
+++ b/include/linux/of_mdio.h
@@ -55,7 +55,7 @@ static inline int of_mdio_parse_addr(struct device *dev,
}
#else /* CONFIG_OF_MDIO */
-static bool of_mdiobus_child_is_phy(struct device_node *child)
+static inline bool of_mdiobus_child_is_phy(struct device_node *child)
{
return false;
}
--
2.24.1
next reply other threads:[~2019-12-23 13:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-23 13:24 Jason A. Donenfeld [this message]
2019-12-23 15:24 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191223132443.115540-1-Jason@zx2c4.com \
--to=jason@zx2c4.com \
--cc=antoine.tenart@bootlin.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®