From: Andrew Lunn <andrew@lunn.ch>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
davem@davemloft.net, Antoine Tenart <antoine.tenart@bootlin.com>
Subject: Re: [PATCH net] of: mdio: mark stub of_mdiobus_child_is_phy as inline
Date: Mon, 23 Dec 2019 16:24:07 +0100 [thread overview]
Message-ID: <20191223152407.GM32356@lunn.ch> (raw)
In-Reply-To: <20191223132443.115540-1-Jason@zx2c4.com>
On Mon, Dec 23, 2019 at 02:24:43PM +0100, Jason A. Donenfeld wrote:
> The of_mdiobus_child_is_phy function was recently exported, with a stub
> fallback added to simply return false as a static function. The inline
> specifier was left out, leading to build time errors:
>
> In file included from linux/include/linux/fs_enet_pd.h:21,
> from linux/arch/powerpc/sysdev/fsl_soc.c:26:
> linux/include/linux/of_mdio.h:58:13: error: ‘of_mdiobus_child_is_phy’ defined but not used [-Werror=unused-function]
> 58 | static bool of_mdiobus_child_is_phy(struct device_node *child)
> | ^~~~~~~~~~
>
> This commit simply adds the missing inline keyboard.
Hi Jason
It is a good idea to search the netdev list before fixing things like
this:
https://lkml.org/lkml/2019/12/23/128
Andrew
prev parent reply other threads:[~2019-12-23 15:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-23 13:24 Jason A. Donenfeld
2019-12-23 15:24 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191223152407.GM32356@lunn.ch \
--to=andrew@lunn.ch \
--cc=Jason@zx2c4.com \
--cc=antoine.tenart@bootlin.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®