* [PATCH] Removing a dead definition or RSB_FILL_LOOPS
@ 2019-12-26 20:45 Anthony Steinhauser
2020-01-02 10:07 ` [tip: x86/cleanups] x86/nospec: Remove unused RSB_FILL_LOOPS tip-bot2 for Anthony Steinhauser
0 siblings, 1 reply; 2+ messages in thread
From: Anthony Steinhauser @ 2019-12-26 20:45 UTC (permalink / raw)
To: linux-kernel; +Cc: mingo, bp, tglx, Anthony Steinhauser
It is never used, but it is misleading.
Signed-off-by: Anthony Steinhauser <asteinhauser@google.com>
---
arch/x86/include/asm/nospec-branch.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/x86/include/asm/nospec-branch.h b/arch/x86/include/asm/nospec-branch.h
index 5c24a7b35166..07e95dcb40ad 100644
--- a/arch/x86/include/asm/nospec-branch.h
+++ b/arch/x86/include/asm/nospec-branch.h
@@ -37,7 +37,6 @@
*/
#define RSB_CLEAR_LOOPS 32 /* To forcibly overwrite all entries */
-#define RSB_FILL_LOOPS 16 /* To avoid underflow */
/*
* Google experimented with loop-unrolling and this turned out to be
--
2.24.1.735.g03f4e72817-goog
^ permalink raw reply [flat|nested] 2+ messages in thread
* [tip: x86/cleanups] x86/nospec: Remove unused RSB_FILL_LOOPS
2019-12-26 20:45 [PATCH] Removing a dead definition or RSB_FILL_LOOPS Anthony Steinhauser
@ 2020-01-02 10:07 ` tip-bot2 for Anthony Steinhauser
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot2 for Anthony Steinhauser @ 2020-01-02 10:07 UTC (permalink / raw)
To: linux-tip-commits
Cc: Anthony Steinhauser, Borislav Petkov, H. Peter Anvin,
Ingo Molnar, Peter Zijlstra, Thomas Gleixner, x86-ml, LKML
The following commit has been merged into the x86/cleanups branch of tip:
Commit-ID: fae7bfcc78146057ac2730719de8d5e41de19540
Gitweb: https://git.kernel.org/tip/fae7bfcc78146057ac2730719de8d5e41de19540
Author: Anthony Steinhauser <asteinhauser@google.com>
AuthorDate: Thu, 26 Dec 2019 12:45:12 -08:00
Committer: Borislav Petkov <bp@suse.de>
CommitterDate: Thu, 02 Jan 2020 10:54:53 +01:00
x86/nospec: Remove unused RSB_FILL_LOOPS
It was never really used, see
117cc7a908c8 ("x86/retpoline: Fill return stack buffer on vmexit")
[ bp: Massage. ]
Signed-off-by: Anthony Steinhauser <asteinhauser@google.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: x86-ml <x86@kernel.org>
Link: https://lkml.kernel.org/r/20191226204512.24524-1-asteinhauser@google.com
---
arch/x86/include/asm/nospec-branch.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/x86/include/asm/nospec-branch.h b/arch/x86/include/asm/nospec-branch.h
index 5c24a7b..07e95dc 100644
--- a/arch/x86/include/asm/nospec-branch.h
+++ b/arch/x86/include/asm/nospec-branch.h
@@ -37,7 +37,6 @@
*/
#define RSB_CLEAR_LOOPS 32 /* To forcibly overwrite all entries */
-#define RSB_FILL_LOOPS 16 /* To avoid underflow */
/*
* Google experimented with loop-unrolling and this turned out to be
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-02 10:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-26 20:45 [PATCH] Removing a dead definition or RSB_FILL_LOOPS Anthony Steinhauser
2020-01-02 10:07 ` [tip: x86/cleanups] x86/nospec: Remove unused RSB_FILL_LOOPS tip-bot2 for Anthony Steinhauser
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®