From: Arvind Sankar <nivedita@alum.mit.edu>
To: Arvind Sankar <nivedita@alum.mit.edu>
Cc: Dominik Brodowski <linux@dominikbrodowski.net>,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
viro@zeniv.linux.org.uk, youling257@gmail.com
Subject: Re: [PATCH] early init: open /dev/console with O_LARGEFILE
Date: Wed, 1 Jan 2020 13:32:44 -0500 [thread overview]
Message-ID: <20200101183243.GB183871@rani.riverdale.lan> (raw)
In-Reply-To: <20200101003017.GA116793@rani.riverdale.lan>
On Tue, Dec 31, 2019 at 07:30:19PM -0500, Arvind Sankar wrote:
> On Tue, Dec 31, 2019 at 04:02:26PM +0100, Dominik Brodowski wrote:
> > If force_o_largefile() is true, /dev/console used to be opened
> > with O_LARGEFILE. Retain that behaviour.
> >
>
> One other thing that used to happen is fsnotify_open() -- I don't know
> how that might affect this, but it seems like the only thing left that's
> different.
Also, this shouldn't impact the current issue I think, but won't doing
filp_open followed by 3 f_dupfd's cause the file->f_count to become 4
but with only 3 open fd's? Don't we have to do an fd_install for the
first one and only 2 f_dupfd's?
next prev parent reply other threads:[~2020-01-01 18:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-31 15:02 Dominik Brodowski
2019-12-31 15:55 ` youling 257
2020-01-01 0:30 ` Arvind Sankar
2020-01-01 10:43 ` Dominik Brodowski
2020-01-01 13:27 ` youling 257
2020-01-01 17:24 ` Dominik Brodowski
2020-01-01 17:59 ` Arvind Sankar
2020-01-01 18:42 ` Dominik Brodowski
2020-01-01 18:49 ` youling 257
2020-01-01 18:32 ` Arvind Sankar [this message]
2020-01-01 21:39 ` Linus Torvalds
2020-01-01 22:50 ` Arvind Sankar
2020-01-01 23:01 ` Linus Torvalds
2020-01-01 23:08 ` Arvind Sankar
2020-01-02 3:09 ` youling 257
2020-01-02 4:00 ` Linus Torvalds
2020-01-02 4:10 ` Arvind Sankar
2020-01-02 17:53 ` Dominik Brodowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200101183243.GB183871@rani.riverdale.lan \
--to=nivedita@alum.mit.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=youling257@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®