From: Arvind Sankar <nivedita@alum.mit.edu>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Arvind Sankar <nivedita@alum.mit.edu>,
Dominik Brodowski <linux@dominikbrodowski.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
youling 257 <youling257@gmail.com>
Subject: Re: [PATCH] early init: open /dev/console with O_LARGEFILE
Date: Wed, 1 Jan 2020 18:08:46 -0500 [thread overview]
Message-ID: <20200101230845.GA454720@rani.riverdale.lan> (raw)
In-Reply-To: <CAHk-=wgHg8z5WQBoypjyi0VPp3E44oO_Szuvk9f6v1mGMqsSZg@mail.gmail.com>
On Wed, Jan 01, 2020 at 03:01:12PM -0800, Linus Torvalds wrote:
> On Wed, Jan 1, 2020 at 2:50 PM Arvind Sankar <nivedita@alum.mit.edu> wrote:
> >
> > Shouldn't that only affect init though? The getty's it spawns should be
> > in their own sessions.
>
> They *should* be in their own sessions, and clearly this problem
> doesn't seem to really affect much anybody else.
>
> But I think youling has some limited and/or odd init userspace, and I
> think it gets confused.
>
> So my theory is that because of the file descriptor leak, that "forget
> the old controlling tty" doesn't happen, and then subsequent tty opens
> don't do the right thing.
>
> Maybe.
>
> But it's the only real semantic change I can see in that whole patch.
>
> Linus
Ok. If you do end up going with this rather than the revert, one minor
nit with the patch -- if somehow the filp_open succeeds but one of the
f_dupfd's fails, you still need to do an fput to avoid leaking the
reference.
next prev parent reply other threads:[~2020-01-01 23:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-31 15:02 Dominik Brodowski
2019-12-31 15:55 ` youling 257
2020-01-01 0:30 ` Arvind Sankar
2020-01-01 10:43 ` Dominik Brodowski
2020-01-01 13:27 ` youling 257
2020-01-01 17:24 ` Dominik Brodowski
2020-01-01 17:59 ` Arvind Sankar
2020-01-01 18:42 ` Dominik Brodowski
2020-01-01 18:49 ` youling 257
2020-01-01 18:32 ` Arvind Sankar
2020-01-01 21:39 ` Linus Torvalds
2020-01-01 22:50 ` Arvind Sankar
2020-01-01 23:01 ` Linus Torvalds
2020-01-01 23:08 ` Arvind Sankar [this message]
2020-01-02 3:09 ` youling 257
2020-01-02 4:00 ` Linus Torvalds
2020-01-02 4:10 ` Arvind Sankar
2020-01-02 17:53 ` Dominik Brodowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200101230845.GA454720@rani.riverdale.lan \
--to=nivedita@alum.mit.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=youling257@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®