mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] perf tools: arm-spe: fix endless record after being terminated
@ 2020-01-02  7:40 Wei Li
  0 siblings, 0 replies; only message in thread
From: Wei Li @ 2020-01-02  7:40 UTC (permalink / raw)
  To: acme, mark.rutland, alexander.shishkin, jolsa, namhyung,
	suzuki.poulose, mathieu.poirier, ilubashe
  Cc: peterz, mingo, linux-arm-kernel, linux-kernel, huawei.libin

In __cmd_record(), when receiving SIGINT(ctrl + c), a done flag will
be set and the event list will be disabled by evlist__disable() once.

While in auxtrace_record.read_finish(), the related events will be
enabled again, if they are continuous, the recording seems to be endless.

If the arm_spe event is disabled, we don't enable it again here.

Before the patch:
[root@localhost ~]# ./perf record -e arm_spe_0/ts_enable=1,pct_enable=1,\
pa_enable=1,load_filter=1,jitter=1,store_filter=1,min_latency=0/ -p 5387
^C^C^C^C^C^C

After the patch:
[root@localhost ~]# ./perf record -e arm_spe_0/ts_enable=1,pct_enable=1,\
pa_enable=1,load_filter=1,jitter=1,store_filter=1,min_latency=0/ -p 5387
^C[ perf record: Woken up 0 times to write data ]
Warning:
AUX data lost 255 times out of 789!

[ perf record: Captured and wrote 1020.719 MB perf.data ]

Signed-off-by: Wei Li <liwei391@huawei.com>
---
 tools/perf/arch/arm64/util/arm-spe.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/tools/perf/arch/arm64/util/arm-spe.c b/tools/perf/arch/arm64/util/arm-spe.c
index eba6541ec0f1..d1ff278a8ab2 100644
--- a/tools/perf/arch/arm64/util/arm-spe.c
+++ b/tools/perf/arch/arm64/util/arm-spe.c
@@ -165,9 +165,13 @@ static int arm_spe_read_finish(struct auxtrace_record *itr, int idx)
 	struct evsel *evsel;
 
 	evlist__for_each_entry(sper->evlist, evsel) {
-		if (evsel->core.attr.type == sper->arm_spe_pmu->type)
-			return perf_evlist__enable_event_idx(sper->evlist,
-							     evsel, idx);
+		if (evsel->core.attr.type == sper->arm_spe_pmu->type) {
+			if (evsel->disabled)
+				return 0;
+			else
+				return perf_evlist__enable_event_idx(
+						sper->evlist, evsel, idx);
+		}
 	}
 	return -EINVAL;
 }
-- 
2.17.1


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-01-02  7:26 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-02  7:40 [PATCH] perf tools: arm-spe: fix endless record after being terminated Wei Li

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®