* [PATCH] gpio: altera: change to platform_get_irq_optional to avoid false-positive error
@ 2020-01-08 16:16 Ooi, Joyce
2020-01-09 9:38 ` Bartosz Golaszewski
0 siblings, 1 reply; 2+ messages in thread
From: Ooi, Joyce @ 2020-01-08 16:16 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski
Cc: linux-gpio, linux-kernel, Joyce Ooi, See Chin Liang, Tan Ley Foon, Ooi
This patch switches to platform_get_irq_optional() from
platform_get_irq() as it causes a false-positive error such as 'IRQ
index 0 not found' when IRQ is not used. The IRQ usage is optional in
this gpio-altera driver, so the error log is undesirable.
Signed-off-by: Ooi, Joyce <joyce.ooi@intel.com>
---
drivers/gpio/gpio-altera.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-altera.c b/drivers/gpio/gpio-altera.c
index 9f2e6b04c361..cc4ba71e4fe3 100644
--- a/drivers/gpio/gpio-altera.c
+++ b/drivers/gpio/gpio-altera.c
@@ -266,7 +266,7 @@ static int altera_gpio_probe(struct platform_device *pdev)
altera_gc->mmchip.gc.owner = THIS_MODULE;
altera_gc->mmchip.gc.parent = &pdev->dev;
- altera_gc->mapped_irq = platform_get_irq(pdev, 0);
+ altera_gc->mapped_irq = platform_get_irq_optional(pdev, 0);
if (altera_gc->mapped_irq < 0)
goto skip_irq;
--
2.13.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio: altera: change to platform_get_irq_optional to avoid false-positive error
2020-01-08 16:16 [PATCH] gpio: altera: change to platform_get_irq_optional to avoid false-positive error Ooi, Joyce
@ 2020-01-09 9:38 ` Bartosz Golaszewski
0 siblings, 0 replies; 2+ messages in thread
From: Bartosz Golaszewski @ 2020-01-09 9:38 UTC (permalink / raw)
To: Ooi, Joyce; +Cc: Linus Walleij, linux-gpio, LKML, See Chin Liang, Tan Ley Foon
śr., 8 sty 2020 o 17:16 Ooi, Joyce <joyce.ooi@intel.com> napisał(a):
>
> This patch switches to platform_get_irq_optional() from
> platform_get_irq() as it causes a false-positive error such as 'IRQ
> index 0 not found' when IRQ is not used. The IRQ usage is optional in
> this gpio-altera driver, so the error log is undesirable.
>
> Signed-off-by: Ooi, Joyce <joyce.ooi@intel.com>
Patch applied, thanks!
Bartosz
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-09 9:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-08 16:16 [PATCH] gpio: altera: change to platform_get_irq_optional to avoid false-positive error Ooi, Joyce
2020-01-09 9:38 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®