* [PATCH] i915: ggtt: include asm/smp.h
@ 2020-01-10 15:17 Arnd Bergmann
2020-01-10 15:25 ` Chris Wilson
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2020-01-10 15:17 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, David Airlie,
Daniel Vetter, Chris Wilson, Matthew Auld
Cc: Arnd Bergmann, intel-gfx, dri-devel, linux-kernel
Splitting up the i915_gem_gtt caused a build failure in some configurations:
drivers/gpu/drm/i915/gt/intel_ggtt.c: In function 'ggtt_restore_mappings':
drivers/gpu/drm/i915/gt/intel_ggtt.c:1239:3: error: implicit declaration of function 'wbinvd_on_all_cpus'; did you mean 'wrmsr_on_cpus'? [-Werror=implicit-function-declaration]
wbinvd_on_all_cpus();
^~~~~~~~~~~~~~~~~~
wrmsr_on_cpus
Add the missing header file.
Fixes: 2c86e55d2ab5 ("drm/i915/gtt: split up i915_gem_gtt")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
I ran into this bug a few days ago on linux-next. Please just ignore
if it's already fixed in the meantime.
---
drivers/gpu/drm/i915/gt/intel_ggtt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/gt/intel_ggtt.c b/drivers/gpu/drm/i915/gt/intel_ggtt.c
index 1a2b5dcde960..9ef8ed85a738 100644
--- a/drivers/gpu/drm/i915/gt/intel_ggtt.c
+++ b/drivers/gpu/drm/i915/gt/intel_ggtt.c
@@ -6,6 +6,7 @@
#include <linux/stop_machine.h>
#include <asm/set_memory.h>
+#include <asm/smp.h>
#include "intel_gt.h"
#include "i915_drv.h"
--
2.20.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] i915: ggtt: include asm/smp.h
2020-01-10 15:17 [PATCH] i915: ggtt: include asm/smp.h Arnd Bergmann
@ 2020-01-10 15:25 ` Chris Wilson
0 siblings, 0 replies; 2+ messages in thread
From: Chris Wilson @ 2020-01-10 15:25 UTC (permalink / raw)
To: Arnd Bergmann, Daniel Vetter, David Airlie, Jani Nikula,
Joonas Lahtinen, Matthew Auld, Rodrigo Vivi
Cc: Arnd Bergmann, intel-gfx, dri-devel, linux-kernel
Quoting Arnd Bergmann (2020-01-10 15:17:54)
> Splitting up the i915_gem_gtt caused a build failure in some configurations:
>
> drivers/gpu/drm/i915/gt/intel_ggtt.c: In function 'ggtt_restore_mappings':
> drivers/gpu/drm/i915/gt/intel_ggtt.c:1239:3: error: implicit declaration of function 'wbinvd_on_all_cpus'; did you mean 'wrmsr_on_cpus'? [-Werror=implicit-function-declaration]
> wbinvd_on_all_cpus();
> ^~~~~~~~~~~~~~~~~~
> wrmsr_on_cpus
>
> Add the missing header file.
>
> Fixes: 2c86e55d2ab5 ("drm/i915/gtt: split up i915_gem_gtt")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> I ran into this bug a few days ago on linux-next. Please just ignore
> if it's already fixed in the meantime.
Fixed applied this morning, thanks for the fixup anyway.
-Chris
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-10 15:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-10 15:17 [PATCH] i915: ggtt: include asm/smp.h Arnd Bergmann
2020-01-10 15:25 ` Chris Wilson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®