From: George Spelvin <lkml@sdf.org>
To: samitolvanen@google.com
Cc: akpm@linux-foundation.org, andriy.shevchenko@linux.intel.com,
keescook@chromium.org, linux-kernel@vger.kernel.org,
linux@rasmusvillemoes.dk, lkml@sdf.org,
mchehab+samsung@kernel.org, st5pub@yandex.ru
Subject: Re: [PATCH] lib/list_sort: fix function type mismatches
Date: Sat, 11 Jan 2020 08:30:28 GMT [thread overview]
Message-ID: <202001110830.00B8USV0024843@sdf.org> (raw)
In-Reply-To: <20200110225602.91663-1-samitolvanen@google.com>
> typedef int __attribute__((nonnull(2,3))) (*cmp_func)(void *,
> - struct list_head const *, struct list_head const *);
> + struct list_head *, struct list_head *);
I'd prefer to leave the const there for documentation.
Does anyone object to fixing it in the other direction by *adding*
const to all the call sites?
Andy Shevchenko posted a patch last 7 October that did that.
<20191007135656.37734-1-andriy.shevchenko@linux.intel.com>
(You could also try taking a second look at why __pure doesn't work,
per AKPM's message of 16 April
<20190416154522.65aaa348161fc581181b56d9@linux-foundation.org>)
next prev parent reply other threads:[~2020-01-11 8:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 22:56 Sami Tolvanen
2020-01-11 8:30 ` George Spelvin [this message]
2020-01-11 10:35 ` Andy Shevchenko
2020-01-11 10:55 ` Andy Shevchenko
2020-01-11 11:44 ` George Spelvin
2020-01-11 23:22 ` George Spelvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202001110830.00B8USV0024843@sdf.org \
--to=lkml@sdf.org \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mchehab+samsung@kernel.org \
--cc=samitolvanen@google.com \
--cc=st5pub@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®