From: Cengiz Can <cengiz@kernel.wtf>
To: prabhakar.csengg@gmail.com
Cc: cengiz@kernel.wtf, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org, mchehab@kernel.org
Subject: [PATCH v2] media: davinci: fix incorrect pix_fmt assignment
Date: Thu, 16 Jan 2020 18:12:30 +0300 [thread overview]
Message-ID: <20200116151229.1002224-1-cengiz@kernel.wtf> (raw)
In-Reply-To: <CA+V-a8vowxJhV0FnHA8kGcLPLWLi8Xd7RSTABLDBtu7YpLYg9Q@mail.gmail.com>
There's a mistakenly written self assignment in
`static int vpfe_enum_fmt_vid_cap(..)`.
Fixed it according to Prabhakar Lad's feedback.
Signed-off-by: Cengiz Can <cengiz@kernel.wtf>
---
drivers/media/platform/davinci/vpfe_capture.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/davinci/vpfe_capture.c b/drivers/media/platform/davinci/vpfe_capture.c
index 916ed743d716..357f7ade5218 100644
--- a/drivers/media/platform/davinci/vpfe_capture.c
+++ b/drivers/media/platform/davinci/vpfe_capture.c
@@ -879,7 +879,7 @@ static int vpfe_enum_fmt_vid_cap(struct file *file, void *priv,
/* Fill in the information about format */
pix_fmt = vpfe_lookup_pix_format(pix);
if (pix_fmt) {
- fmt->pixelformat = fmt->pixelformat;
+ fmt->pixelformat = pix_fmt->pixelformat;
return 0;
}
return -EINVAL;
--
2.25.0
prev parent reply other threads:[~2020-01-16 15:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 17:20 [PATCH] media: davinci: remove self assignment in vpfe Cengiz Can
2020-01-14 14:26 ` Lad, Prabhakar
2020-01-16 15:12 ` Cengiz Can [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200116151229.1002224-1-cengiz@kernel.wtf \
--to=cengiz@kernel.wtf \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=prabhakar.csengg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®