* [PATCH] media: davinci: remove self assignment in vpfe
@ 2020-01-13 17:20 Cengiz Can
2020-01-14 14:26 ` Lad, Prabhakar
0 siblings, 1 reply; 3+ messages in thread
From: Cengiz Can @ 2020-01-13 17:20 UTC (permalink / raw)
To: Lad, Prabhakar, Mauro Carvalho Chehab
Cc: linux-media, linux-kernel, Cengiz Can
There's a self assignment which has no effect.
Removed self assignment.
Signed-off-by: Cengiz Can <cengiz@kernel.wtf>
---
drivers/media/platform/davinci/vpfe_capture.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/platform/davinci/vpfe_capture.c b/drivers/media/platform/davinci/vpfe_capture.c
index 916ed743d716..089648665cdf 100644
--- a/drivers/media/platform/davinci/vpfe_capture.c
+++ b/drivers/media/platform/davinci/vpfe_capture.c
@@ -879,7 +879,6 @@ static int vpfe_enum_fmt_vid_cap(struct file *file, void *priv,
/* Fill in the information about format */
pix_fmt = vpfe_lookup_pix_format(pix);
if (pix_fmt) {
- fmt->pixelformat = fmt->pixelformat;
return 0;
}
return -EINVAL;
--
2.24.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] media: davinci: remove self assignment in vpfe
2020-01-13 17:20 [PATCH] media: davinci: remove self assignment in vpfe Cengiz Can
@ 2020-01-14 14:26 ` Lad, Prabhakar
2020-01-16 15:12 ` [PATCH v2] media: davinci: fix incorrect pix_fmt assignment Cengiz Can
0 siblings, 1 reply; 3+ messages in thread
From: Lad, Prabhakar @ 2020-01-14 14:26 UTC (permalink / raw)
To: Cengiz Can; +Cc: Mauro Carvalho Chehab, linux-media, LKML
Hi Cengiz,
Thank you for the patch.
On Mon, Jan 13, 2020 at 5:21 PM Cengiz Can <cengiz@kernel.wtf> wrote:
>
> There's a self assignment which has no effect.
>
> Removed self assignment.
>
> Signed-off-by: Cengiz Can <cengiz@kernel.wtf>
> ---
> drivers/media/platform/davinci/vpfe_capture.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/platform/davinci/vpfe_capture.c b/drivers/media/platform/davinci/vpfe_capture.c
> index 916ed743d716..089648665cdf 100644
> --- a/drivers/media/platform/davinci/vpfe_capture.c
> +++ b/drivers/media/platform/davinci/vpfe_capture.c
> @@ -879,7 +879,6 @@ static int vpfe_enum_fmt_vid_cap(struct file *file, void *priv,
> /* Fill in the information about format */
> pix_fmt = vpfe_lookup_pix_format(pix);
> if (pix_fmt) {
> - fmt->pixelformat = fmt->pixelformat;
good catch, but the correct fix is to assign pix_fmt->pixelformat to
fmt->pixelformat.
Cheers,
--Prabhakar Lad
> return 0;
> }
> return -EINVAL;
> --
> 2.24.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH v2] media: davinci: fix incorrect pix_fmt assignment
2020-01-14 14:26 ` Lad, Prabhakar
@ 2020-01-16 15:12 ` Cengiz Can
0 siblings, 0 replies; 3+ messages in thread
From: Cengiz Can @ 2020-01-16 15:12 UTC (permalink / raw)
To: prabhakar.csengg; +Cc: cengiz, linux-kernel, linux-media, mchehab
There's a mistakenly written self assignment in
`static int vpfe_enum_fmt_vid_cap(..)`.
Fixed it according to Prabhakar Lad's feedback.
Signed-off-by: Cengiz Can <cengiz@kernel.wtf>
---
drivers/media/platform/davinci/vpfe_capture.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/davinci/vpfe_capture.c b/drivers/media/platform/davinci/vpfe_capture.c
index 916ed743d716..357f7ade5218 100644
--- a/drivers/media/platform/davinci/vpfe_capture.c
+++ b/drivers/media/platform/davinci/vpfe_capture.c
@@ -879,7 +879,7 @@ static int vpfe_enum_fmt_vid_cap(struct file *file, void *priv,
/* Fill in the information about format */
pix_fmt = vpfe_lookup_pix_format(pix);
if (pix_fmt) {
- fmt->pixelformat = fmt->pixelformat;
+ fmt->pixelformat = pix_fmt->pixelformat;
return 0;
}
return -EINVAL;
--
2.25.0
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-16 15:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-13 17:20 [PATCH] media: davinci: remove self assignment in vpfe Cengiz Can
2020-01-14 14:26 ` Lad, Prabhakar
2020-01-16 15:12 ` [PATCH v2] media: davinci: fix incorrect pix_fmt assignment Cengiz Can
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®