From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: "yukuai (C)" <yukuai3@huawei.com>
Cc: thierry.reding@gmail.com, linux-pwm@vger.kernel.org,
linux-kernel@vger.kernel.org, zhengbin13@huawei.com,
yi.zhang@huawei.com
Subject: Re: [PATCH] pwm: remove set but not set variable 'pwm'
Date: Mon, 20 Jan 2020 12:48:32 +0100 [thread overview]
Message-ID: <20200120114832.uqa4dthodltu6xdv@pengutronix.de> (raw)
In-Reply-To: <55871ad5-4cb0-f3c8-a408-2c1be894126a@huawei.com>
On Mon, Jan 20, 2020 at 07:40:37PM +0800, yukuai (C) wrote:
> On 2020/1/20 15:34, Uwe Kleine-König wrote:
> > Fixes: e926b12c611c ("pwm: Clear chip_data in pwm_put()")
>
> Thank you for your advise! I'll add 'Fixes' in a V2 patch.
>
> > Did you check that dropping the locking is save? (I didn't)
> >
> > I'd assume that no harm is introduced, but mentioning that in the commit
> > log would be good.
>
> I think dropping the lock is safe since there is nothing to be done
> inside the lock. However, I didn't run a full test. By the way, I'll
> mentioning it in a V2 patch.
There are (rare) situations where taking and dropping a lock might make
sense. For example if you have a another context and want to make sure
that a shared resource isn't about to be used.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
prev parent reply other threads:[~2020-01-20 11:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-19 12:22 yu kuai
2020-01-20 7:34 ` Uwe Kleine-König
2020-01-20 11:40 ` yukuai (C)
2020-01-20 11:48 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200120114832.uqa4dthodltu6xdv@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®