From: "yukuai (C)" <yukuai3@huawei.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: <thierry.reding@gmail.com>, <linux-pwm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <zhengbin13@huawei.com>,
<yi.zhang@huawei.com>
Subject: Re: [PATCH] pwm: remove set but not set variable 'pwm'
Date: Mon, 20 Jan 2020 19:40:37 +0800 [thread overview]
Message-ID: <55871ad5-4cb0-f3c8-a408-2c1be894126a@huawei.com> (raw)
In-Reply-To: <20200120073407.ck2fmk7qdvqsfqsy@pengutronix.de>
On 2020/1/20 15:34, Uwe Kleine-König wrote:
> Fixes: e926b12c611c ("pwm: Clear chip_data in pwm_put()")
Thank you for your advise! I'll add 'Fixes' in a V2 patch.
> Did you check that dropping the locking is save? (I didn't)
>
> I'd assume that no harm is introduced, but mentioning that in the commit
> log would be good.
I think dropping the lock is safe since there is nothing to be done
inside the lock. However, I didn't run a full test. By the way, I'll
mentioning it in a V2 patch.
Thanks!
Yu Kuai
next prev parent reply other threads:[~2020-01-20 11:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-19 12:22 yu kuai
2020-01-20 7:34 ` Uwe Kleine-König
2020-01-20 11:40 ` yukuai (C) [this message]
2020-01-20 11:48 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55871ad5-4cb0-f3c8-a408-2c1be894126a@huawei.com \
--to=yukuai3@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=yi.zhang@huawei.com \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®