From: Peter Zijlstra <peterz@infradead.org>
To: Benjamin Thiel <b.thiel@posteo.de>
Cc: X86 ML <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kernel/events: Add a missing prototype for arch_perf_update_userpage()
Date: Mon, 20 Jan 2020 16:31:25 +0100 [thread overview]
Message-ID: <20200120153125.GE14897@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20200109131351.9468-1-b.thiel@posteo.de>
On Thu, Jan 09, 2020 at 02:13:51PM +0100, Benjamin Thiel wrote:
> ... in order to fix a -Wmissing-prototype warning.
>
> No functional changes.
>
> Signed-off-by: Benjamin Thiel <b.thiel@posteo.de>
> ---
> include/linux/perf_event.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
> index 6d4c22aee384..de3874271814 100644
> --- a/include/linux/perf_event.h
> +++ b/include/linux/perf_event.h
> @@ -1544,4 +1544,7 @@ int perf_event_exit_cpu(unsigned int cpu);
> #define perf_event_exit_cpu NULL
> #endif
>
> +void __weak arch_perf_update_userpage(
> + struct perf_event *event, struct perf_event_mmap_page *userpg, u64 now);
> +
Indeed so, I've slightly changed to:
+extern void __weak arch_perf_update_userpage(struct perf_event *event,
+ struct perf_event_mmap_page *userpg,
+ u64 now);
Thanks!
next prev parent reply other threads:[~2020-01-20 15:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 13:13 Benjamin Thiel
2020-01-20 15:31 ` Peter Zijlstra [this message]
2020-01-29 11:32 ` [tip: perf/urgent] " tip-bot2 for Benjamin Thiel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200120153125.GE14897@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=b.thiel@posteo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®