[PATCH] kernel/events: Add a missing prototype for arch_perf_update_userpage()

[PATCH] kernel/events: Add a missing prototype for arch_perf_update_userpage()

[Benjamin Thiel]

... in order to fix a -Wmissing-prototype warning.

No functional changes.

Signed-off-by: Benjamin Thiel <b.thiel@posteo.de>
---
 include/linux/perf_event.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
index 6d4c22aee384..de3874271814 100644
--- a/include/linux/perf_event.h
+++ b/include/linux/perf_event.h
@@ -1544,4 +1544,7 @@ int perf_event_exit_cpu(unsigned int cpu);
 #define perf_event_exit_cpu	NULL
 #endif
 
+void __weak arch_perf_update_userpage(
+	struct perf_event *event, struct perf_event_mmap_page *userpg, u64 now);
+
 #endif /* _LINUX_PERF_EVENT_H */
-- 
2.17.1

Re: [PATCH] kernel/events: Add a missing prototype for arch_perf_update_userpage()

[Peter Zijlstra]

On Thu, Jan 09, 2020 at 02:13:51PM +0100, Benjamin Thiel wrote:
> ... in order to fix a -Wmissing-prototype warning.
> 
> No functional changes.
> 
> Signed-off-by: Benjamin Thiel <b.thiel@posteo.de>
> ---
>  include/linux/perf_event.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
> index 6d4c22aee384..de3874271814 100644
> --- a/include/linux/perf_event.h
> +++ b/include/linux/perf_event.h
> @@ -1544,4 +1544,7 @@ int perf_event_exit_cpu(unsigned int cpu);
>  #define perf_event_exit_cpu	NULL
>  #endif
>  
> +void __weak arch_perf_update_userpage(
> +	struct perf_event *event, struct perf_event_mmap_page *userpg, u64 now);
> +

Indeed so, I've slightly changed to:

+extern void __weak arch_perf_update_userpage(struct perf_event *event,
+                                            struct perf_event_mmap_page *userpg,
+                                            u64 now);

Thanks!

[tip: perf/urgent] kernel/events: Add a missing prototype for arch_perf_update_userpage()

[tip-bot2 for Benjamin Thiel]

The following commit has been merged into the perf/urgent branch of tip:

Commit-ID:     f1ec3a517b4352e78dbef6b1e591f43202ecb3fe
Gitweb:        https://git.kernel.org/tip/f1ec3a517b4352e78dbef6b1e591f43202ecb3fe
Author:        Benjamin Thiel <b.thiel@posteo.de>
AuthorDate:    Thu, 09 Jan 2020 14:13:51 +01:00
Committer:     Ingo Molnar <mingo@kernel.org>
CommitterDate: Tue, 28 Jan 2020 21:26:44 +01:00

kernel/events: Add a missing prototype for arch_perf_update_userpage()

... in order to fix a -Wmissing-prototype warning.

No functional changes.

Signed-off-by: Benjamin Thiel <b.thiel@posteo.de>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lkml.kernel.org/r/20200109131351.9468-1-b.thiel@posteo.de
---
 include/linux/perf_event.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
index 6d4c22a..52928e0 100644
--- a/include/linux/perf_event.h
+++ b/include/linux/perf_event.h
@@ -1544,4 +1544,8 @@ int perf_event_exit_cpu(unsigned int cpu);
 #define perf_event_exit_cpu	NULL
 #endif
 
+extern void __weak arch_perf_update_userpage(struct perf_event *event,
+					     struct perf_event_mmap_page *userpg,
+					     u64 now);
+
 #endif /* _LINUX_PERF_EVENT_H */